Sign upLogin

avocado-framework/avocado

View on GitHub
Star
avocado/utils/software_manager/backends/apt.py

Summary

Maintainability
A
3 hrs
Test Coverage
F
11%

Function call with shell=True parameter identified, possible security issue.
Open

            process.system(add_cmd, shell=True, sudo=True)
Severity: Minor
Found in avocado/utils/software_manager/backends/apt.py by bandit

Function call with shell=True parameter identified, possible security issue.
Open

        cmd_result = process.run(
            "apt-get -v | head -1", ignore_status=True, verbose=False, shell=True
Severity: Minor
Found in avocado/utils/software_manager/backends/apt.py by bandit

Function call with shell=True parameter identified, possible security issue.
Open

            process.system(up_cmd, shell=True, sudo=True)
Severity: Minor
Found in avocado/utils/software_manager/backends/apt.py by bandit

Function call with shell=True parameter identified, possible security issue.
Open

            process.system(i_cmd, shell=True, sudo=True)
Severity: Minor
Found in avocado/utils/software_manager/backends/apt.py by bandit

Function provides has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    def provides(self, name):
        """
        Return a list of packages that provide [name of package/file].

        :param name: File name.
Severity: Minor
Found in avocado/utils/software_manager/backends/apt.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function get_source has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    def get_source(self, name, path):
        """
        Download source for provided package. Returns the path with source placed.

        :param name: parameter wildcard package to get the source for
Severity: Minor
Found in avocado/utils/software_manager/backends/apt.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status