Sign upLogin

avocado-framework/avocado

View on GitHub
Star
avocado/utils/ssh.py

Summary

Maintainability
A
1 hr
Test Coverage
F
52%

Consider possible security implications associated with subprocess module.
Open

import subprocess
Severity: Info
Found in avocado/utils/ssh.py by bandit

subprocess call - check for execution of untrusted input.
Open

                master = subprocess.Popen(
                    cmd,
                    stdin=subprocess.DEVNULL,
                    stdout=subprocess.DEVNULL,
                    stderr=subprocess.DEVNULL,
Severity: Info
Found in avocado/utils/ssh.py by bandit

subprocess call - check for execution of untrusted input.
Open

                master = subprocess.Popen(
                    cmd,
                    stdin=subprocess.DEVNULL,
                    stdout=subprocess.DEVNULL,
                    stderr=subprocess.DEVNULL,
Severity: Info
Found in avocado/utils/ssh.py by bandit

Function connect has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def connect(self):
        """
        Establishes the connection to the remote endpoint

        On this implementation, it means creating the master connection,
Severity: Minor
Found in avocado/utils/ssh.py - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function __init__ has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def __init__(self, host, port=None, user=None, key=None, password=None):
Severity: Minor
Found in avocado/utils/ssh.py - About 35 mins to fix

    Function cmd has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def cmd(self, command, ignore_status=True, timeout=None):
        """
        Runs a command over the SSH session

        :param command: the command to execute over the SSH session
    Severity: Minor
    Found in avocado/utils/ssh.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status