avocado-framework/avocado

View on GitHub

Showing 895 of 913 total issues

Function render has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def render(self, result, job):
        json_output = job.config.get("job.run.result.json.output")
        json_enabled = job.config.get("job.run.result.json.enabled")

        if not (json_enabled or json_output):
Severity: Minor
Found in avocado/plugins/jsonresult.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                        if regexp.match(child.name):
                            remove.append(child)
                    for child in remove:

    Function initialize has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def initialize(self, config):
            subcommand = config.get("subcommand")
            self.variants = None  # pylint: disable=W0201
            order = config.get(f"{subcommand}.cit.combination_order")
            if order and order > 6:
    Severity: Minor
    Found in optional_plugins/varianter_cit/avocado_varianter_cit/varianter_cit.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                            if len(c) > len(constraint_array):
                                if set(c) > set(constraint_array):
                                    remove.add(c)
                        if not has_subset:
    Severity: Major
    Found in optional_plugins/varianter_cit/avocado_varianter_cit/Solver.py - About 45 mins to fix

      Function resolve has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def resolve(self, reference):
              if not self.config.get("resolver.run_executables"):
                  return ReferenceResolution(
                      reference,
                      ReferenceResolutionResult.NOTFOUND,
      Severity: Minor
      Found in avocado/plugins/resolvers.py - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _fetch_asset has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def _fetch_asset(name, asset_hash, algorithm, locations, cache_dirs, expire, queue):
      Severity: Minor
      Found in avocado/plugins/runners/asset.py - About 45 mins to fix

        Function run has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            def run(self, config):
                name = config.get("distro.distro_def_name")
                version = config.get("distro.distro_def_version")
                release = config.get("distro.distro_def_release")
                arch = config.get("distro.distro_def_arch")
        Severity: Minor
        Found in avocado/plugins/distro.py - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function _run_scripts has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            def _run_scripts(self, kind, scripts_dir, job):
                config = job.config
                if not os.path.isdir(scripts_dir):
                    if config.get("plugins.jobscripts.warn_non_existing_dir"):
                        LOG_UI.error(
        Severity: Minor
        Found in avocado/plugins/jobscripts.py - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid deeply nested control flow statements.
        Open

                                if candidate not in candidates:
                                    candidates.append(candidate)
        
        
        Severity: Major
        Found in avocado/plugins/assets.py - About 45 mins to fix

          Function hash_file has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

          def hash_file(filename, size=None, algorithm="md5"):
              """
              Calculate the hash value of filename.
          
              If size is not None, limit to first size bytes.
          Severity: Minor
          Found in avocado/utils/crypto.py - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function tokenize has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              def tokenize(self, s):
                  pos = 0
                  n = len(s)
                  while pos < n:
                      m = self.re.match(s, pos)
          Severity: Minor
          Found in avocado/utils/external/spark.py - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid deeply nested control flow statements.
          Open

                              with open(
                                  os.path.join(root, metadata_file), "r", encoding="utf-8"
                              ) as data:
                                  metadata = json.loads(data.read())
                              if isinstance(metadata, dict):
          Severity: Major
          Found in avocado/plugins/vmimage.py - About 45 mins to fix

            Function _save_to_json has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                def _save_to_json(matrix, filename, verbose=False):
                    result = []
                    type_label_mapping = {}
            
                    for line in matrix:
            Severity: Minor
            Found in avocado/plugins/list.py - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function get_distro has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                def get_distro(self):
                    """
                    :param session: ssh connection between another machine
            
                    Returns the :class:`LinuxDistro` this probe detected
            Severity: Minor
            Found in avocado/utils/distro.py - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid deeply nested control flow statements.
            Open

                                if isinstance(metadata, dict):
                                    if metadata.get("type", None) == "vmimage":
                                        provider = None
                                        for p in vmimage.IMAGE_PROVIDERS:
                                            if p.name == metadata["name"]:
            Severity: Major
            Found in avocado/plugins/vmimage.py - About 45 mins to fix

              Function vg_ramdisk has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              def vg_ramdisk(
              Severity: Minor
              Found in avocado/utils/lv_utils.py - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                        if nk is not None:
                                            # self.add(cur, (nk, i))
                                            # INLINED --v
                                            new = (nk, i)
                                            if new not in cur:
                Severity: Major
                Found in avocado/utils/external/spark.py - About 45 mins to fix

                  Function lv_create has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  def lv_create(
                  Severity: Minor
                  Found in avocado/utils/lv_utils.py - About 45 mins to fix

                    Function _namelist has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                    def _namelist(instance):
                        namelist, namedict, classlist = [], {}, [instance.__class__]
                        for c in classlist:
                            for b in c.__bases__:
                                classlist.append(b)  # pylint: disable=W4701
                    Severity: Minor
                    Found in avocado/utils/external/spark.py - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Avoid deeply nested control flow statements.
                    Open

                                            if new not in next_item:
                                                next_item.append(new)
                                            # INLINED --^
                                else:
                    Severity: Major
                    Found in avocado/utils/external/spark.py - About 45 mins to fix
                      Severity
                      Category
                      Status
                      Source
                      Language