Sign upLogin

avocado-framework/avocado

View on GitHub
Star
selftests/unit/utils/service.py

Summary

Maintainability
B
4 hrs
Test Coverage

File service.py has 276 lines of code (exceeds 250 allowed). Consider refactoring.
Open

#  Copyright(c) 2013 Intel Corporation.
#
#  This program is free software; you can redistribute it and/or modify it
#  under the terms and conditions of the GNU General Public License,
#  version 2, as published by the Free Software Foundation.
Severity: Minor
Found in selftests/unit/utils/service.py - About 2 hrs to fix

    Function test_all_commands has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def test_all_commands(self):
        command_name = "service"
        # Test all commands except "set_target" which is tested elsewhere
        for cmd, _ in (
            (c, r)
    Severity: Minor
    Found in selftests/unit/utils/service.py - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function test_all_commands has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def test_all_commands(self):
        # Test all commands except "set_target" which is tested elsewhere
        for cmd, _ in (
            (c, r)
            for (c, r) in self.service_command_generator.commands
    Severity: Minor
    Found in selftests/unit/utils/service.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status