Sign upLogin

badgeteam/Hatchery

View on GitHub
Star
database/migrations/2017_06_13_142609_alter_files_and_versions_add_user_id.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid using static access to class '\Illuminate\Support\Facades\Schema' in method 'up'.
Open

        Schema::table(
            'files',
            function (Blueprint $table) {
                $table->integer('user_id')->unsigned()->nullable()->after('id');
                $table->foreign('user_id')->references('id')->on('users')->onDelete('cascade')->onUpdate('cascade');
Severity: Minor
Found in database/migrations/2017_06_13_142609_alter_files_and_versions_add_user_id.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Support\Facades\Schema' in method 'down'.
Open

        Schema::table(
            'files',
            function (Blueprint $table) {
                $table->dropForeign(['user_id']);
                $table->dropColumn('user_id');
Severity: Minor
Found in database/migrations/2017_06_13_142609_alter_files_and_versions_add_user_id.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Support\Facades\Schema' in method 'up'.
Open

        Schema::table(
            'versions',
            function (Blueprint $table) {
                $table->integer('user_id')->unsigned()->nullable()->after('id');
                $table->foreign('user_id')->references('id')->on('users')->onDelete('cascade')->onUpdate('cascade');
Severity: Minor
Found in database/migrations/2017_06_13_142609_alter_files_and_versions_add_user_id.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Illuminate\Support\Facades\Schema' in method 'down'.
Open

        Schema::table(
            'versions',
            function (Blueprint $table) {
                $table->dropForeign(['user_id']);
                $table->dropColumn('user_id');
Severity: Minor
Found in database/migrations/2017_06_13_142609_alter_files_and_versions_add_user_id.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Define a constant instead of duplicating this literal "user_id" 8 times.
Open

                $table->integer('user_id')->unsigned()->nullable()->after('id');
Severity: Critical
Found in database/migrations/2017_06_13_142609_alter_files_and_versions_add_user_id.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Define a constant instead of duplicating this literal "cascade" 4 times.
Open

                $table->foreign('user_id')->references('id')->on('users')->onDelete('cascade')->onUpdate('cascade');
Severity: Critical
Found in database/migrations/2017_06_13_142609_alter_files_and_versions_add_user_id.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Avoid using short method names like AlterFilesAndVersionsAddUserId::up(). The configured minimum method name length is 3.
Open

    public function up()
    {
        Schema::table(
            'versions',
            function (Blueprint $table) {
Severity: Minor
Found in database/migrations/2017_06_13_142609_alter_files_and_versions_add_user_id.php by phpmd

ShortMethodName

Since: 0.2

Detects when very short method names are used.

Example

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Source https://phpmd.org/rules/naming.html#shortmethodname

Each class must be in a namespace of at least one level (a top-level vendor name)
Open

class AlterFilesAndVersionsAddUserId extends Migration
Severity: Minor
Found in database/migrations/2017_06_13_142609_alter_files_and_versions_add_user_id.php by phpcodesniffer

There are no issues that match your filters.

Category
Status