Showing 536 of 536 total issues
Function onload
has a Cognitive Complexity of 45 (exceeds 5 allowed). Consider refactoring. Open
window.onload = function () {
const ext = document.getElementById('extension');
let langmode = 'python';
if (ext) {
if (ext.getAttribute('value') === 'json') {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function onload
has 155 lines of code (exceeds 25 allowed). Consider refactoring. Open
window.onload = function () {
const ext = document.getElementById('extension');
let langmode = 'python';
if (ext) {
if (ext.getAttribute('value') === 'json') {
File illustrated-layout.blade.php
has 388 lines of code (exceeds 250 allowed). Consider refactoring. Open
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">
Project
has 30 functions (exceeds 20 allowed). Consider refactoring. Open
class Project extends Model
{
use SoftDeletes;
use HasFactory;
Similar blocks of code found in 2 locations. Consider refactoring. Open
<?php
declare(strict_types=1);
namespace App\Models;
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 154.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
<?php
declare(strict_types=1);
namespace App\Models;
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 154.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
File ProjectsController.php
has 310 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
declare(strict_types=1);
namespace App\Http\Controllers;
The class PublicController has 12 public methods. Consider refactoring PublicController to keep number of public methods under 10. Open
class PublicController extends Controller
{
/**
* Fields allowed for ordering the main view ;).
*
- Read upRead up
- Exclude checks
TooManyPublicMethods
Since: 0.1
A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.
By default it ignores methods starting with 'get' or 'set'.
Example
Source https://phpmd.org/rules/codesize.html#toomanypublicmethods
The class FilesController has 12 public methods. Consider refactoring FilesController to keep number of public methods under 10. Open
class FilesController extends Controller
{
/**
* Create a new controller instance.
*/
- Read upRead up
- Exclude checks
TooManyPublicMethods
Since: 0.1
A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.
By default it ignores methods starting with 'get' or 'set'.
Example
Source https://phpmd.org/rules/codesize.html#toomanypublicmethods
The class Project has 12 public methods. Consider refactoring Project to keep number of public methods under 10. Open
class Project extends Model
{
use SoftDeletes;
use HasFactory;
- Read upRead up
- Exclude checks
TooManyPublicMethods
Since: 0.1
A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.
By default it ignores methods starting with 'get' or 'set'.
Example
Source https://phpmd.org/rules/codesize.html#toomanypublicmethods
The class ProjectsController has an overall complexity of 57 which is very high. The configured complexity threshold is 50. Open
class ProjectsController extends Controller
{
/**
* Create a new controller instance.
*/
- Exclude checks
The class Project has an overall complexity of 59 which is very high. The configured complexity threshold is 50. Open
class Project extends Model
{
use SoftDeletes;
use HasFactory;
- Exclude checks
The class ProjectsController has 14 public methods. Consider refactoring ProjectsController to keep number of public methods under 10. Open
class ProjectsController extends Controller
{
/**
* Create a new controller instance.
*/
- Read upRead up
- Exclude checks
TooManyPublicMethods
Since: 0.1
A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.
By default it ignores methods starting with 'get' or 'set'.
Example
Source https://phpmd.org/rules/codesize.html#toomanypublicmethods
File Project.php
has 300 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
declare(strict_types=1);
namespace App\Models;
File app.js
has 298 lines of code (exceeds 250 allowed). Consider refactoring. Open
/* global require */
/**
* First we will load all of this project's JavaScript dependencies which
* includes Vue and other libraries. It is a great starting point when
ProjectsController
has 23 functions (exceeds 20 allowed). Consider refactoring. Open
class ProjectsController extends Controller
{
/**
* Create a new controller instance.
*/
Function pixelToHexA
has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring. Open
window.pixelToHexA = function (rgba) {
let remove = 5;
if (rgba.indexOf('rgba') === -1) {
remove = 4;
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File PublicController.php
has 257 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
declare(strict_types=1);
namespace App\Http\Controllers;
Function pixelToHexA
has 49 lines of code (exceeds 25 allowed). Consider refactoring. Open
window.pixelToHexA = function (rgba) {
let remove = 5;
if (rgba.indexOf('rgba') === -1) {
remove = 4;
}
Avoid excessively long class names like CreateCategoriesTableAlterProjectsAddCategory. Keep class name length under 40. Open
class CreateCategoriesTableAlterProjectsAddCategory extends Migration
{
/**
* Run the migrations.
*
- Read upRead up
- Exclude checks
LongClassName
Since: 2.9
Detects when classes or interfaces are declared with excessively long names.
Example
class ATooLongClassNameThatHintsAtADesignProblem {
}
interface ATooLongInterfaceNameThatHintsAtADesignProblem {
}