Sign upLogin

badgeteam/Hatchery

View on GitHub
Star

Showing 536 of 536 total issues

Avoid excessively long class names like CreateCategoriesTableAlterProjectsAddCategory. Keep class name length under 40.
Open

class CreateCategoriesTableAlterProjectsAddCategory extends Migration
{
    /**
     * Run the migrations.
     *
Severity: Minor
Found in database/migrations/2017_07_03_143514_create_categories_table_alter_projects_add_category.php by phpmd

LongClassName

Since: 2.9

Detects when classes or interfaces are declared with excessively long names.

Example

class ATooLongClassNameThatHintsAtADesignProblem {

}

interface ATooLongInterfaceNameThatHintsAtADesignProblem {

}

Source https://phpmd.org/rules/naming.html#longclassname

Method returnProjectView has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function returnProjectView(Request $request, $projects, string $badge = '')
    {
        $category = '';
        if ($request->has('category')) {
            $category = Category::where('slug', $request->get('category'))->firstOrFail();
Severity: Minor
Found in app/Http/Controllers/PublicController.php - About 1 hr to fix

    Method app has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function app(string $device, string $type, string $category, string $app): JsonResponse
    {
        /** @var Badge $badge */
        $badge = Badge::whereSlug($device)->firstOrFail();
        $categoryId = Category::whereSlug($category)->firstOrFail()->id;
    Severity: Minor
    Found in app/Http/Controllers/MchController.php - About 1 hr to fix

      Function manageBadges has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          private function manageBadges(Project $project, Request $request): void
    {
        if ($request->has('badge_ids')) {
            $project->badges()->detach();
            $badges = Badge::find($request->get('badge_ids'));
      Severity: Minor
      Found in app/Http/Controllers/ProjectsController.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid using short method names like CreatePasswordResetsTable::up(). The configured minimum method name length is 3.
      Open

          public function up()
    {
        Schema::create(
            'password_resets',
            function (Blueprint $table) {
      Severity: Minor
      Found in database/migrations/2014_10_12_100000_create_password_resets_table.php by phpmd

      ShortMethodName

      Since: 0.2

      Detects when very short method names are used.

      Example

      class ShortMethod {
    public function a( $index ) { // Violation
    }
}

      Source https://phpmd.org/rules/naming.html#shortmethodname

      Avoid using short method names like AlterVersionsRemoveDependencies::up(). The configured minimum method name length is 3.
      Open

          public function up()
    {
        Schema::table(
            'versions',
            function (Blueprint $table) {
      Severity: Minor
      Found in database/migrations/2017_06_21_160719_alter_versions_remove_dependencies.php by phpmd

      ShortMethodName

      Since: 0.2

      Detects when very short method names are used.

      Example

      class ShortMethod {
    public function a( $index ) { // Violation
    }
}

      Source https://phpmd.org/rules/naming.html#shortmethodname

      Avoid using short method names like CreateUsersTable::up(). The configured minimum method name length is 3.
      Open

          public function up()
    {
        Schema::create(
            'users',
            function (Blueprint $table) {
      Severity: Minor
      Found in database/migrations/2014_10_12_000000_create_users_table.php by phpmd

      ShortMethodName

      Since: 0.2

      Detects when very short method names are used.

      Example

      class ShortMethod {
    public function a( $index ) { // Violation
    }
}

      Source https://phpmd.org/rules/naming.html#shortmethodname

      Avoid using short method names like AlterProjectsAddDescription::up(). The configured minimum method name length is 3.
      Open

          public function up()
    {
        Schema::table(
            'projects',
            function (Blueprint $table) {
      Severity: Minor
      Found in database/migrations/2017_06_12_133100_alter_projects_add_description.php by phpmd

      ShortMethodName

      Since: 0.2

      Detects when very short method names are used.

      Example

      class ShortMethod {
    public function a( $index ) { // Violation
    }
}

      Source https://phpmd.org/rules/naming.html#shortmethodname

      Avoid using short method names like CreateVersionsTable::up(). The configured minimum method name length is 3.
      Open

          public function up()
    {
        Schema::create(
            'versions',
            function (Blueprint $table) {
      Severity: Minor
      Found in database/migrations/2017_06_12_133331_create_versions_table.php by phpmd

      ShortMethodName

      Since: 0.2

      Detects when very short method names are used.

      Example

      class ShortMethod {
    public function a( $index ) { // Violation
    }
}

      Source https://phpmd.org/rules/naming.html#shortmethodname

      Avoid using short method names like CreateProjectsTable::up(). The configured minimum method name length is 3.
      Open

          public function up()
    {
        Schema::create(
            'projects',
            function (Blueprint $table) {
      Severity: Minor
      Found in database/migrations/2017_05_10_114925_create_projects_table.php by phpmd

      ShortMethodName

      Since: 0.2

      Detects when very short method names are used.

      Example

      class ShortMethod {
    public function a( $index ) { // Violation
    }
}

      Source https://phpmd.org/rules/naming.html#shortmethodname

      Avoid using short method names like AlterProjectsAddSlug::up(). The configured minimum method name length is 3.
      Open

          public function up()
    {
        Schema::table(
            'projects',
            function (Blueprint $table) {
      Severity: Minor
      Found in database/migrations/2017_06_13_100732_alter_projects_add_slug.php by phpmd

      ShortMethodName

      Since: 0.2

      Detects when very short method names are used.

      Example

      class ShortMethod {
    public function a( $index ) { // Violation
    }
}

      Source https://phpmd.org/rules/naming.html#shortmethodname

      Avoid using short method names like AddPublishedAtToProjectsTable::up(). The configured minimum method name length is 3.
      Open

          public function up()
    {
        Schema::table(
            'projects',
            function (Blueprint $table) {
      Severity: Minor
      Found in database/migrations/2019_10_24_180950_add_published_at_to_projects_table.php by phpmd

      ShortMethodName

      Since: 0.2

      Detects when very short method names are used.

      Example

      class ShortMethod {
    public function a( $index ) { // Violation
    }
}

      Source https://phpmd.org/rules/naming.html#shortmethodname

      Avoid using short method names like CreateVotesTable::up(). The configured minimum method name length is 3.
      Open

          public function up()
    {
        Schema::create(
            'votes',
            function (Blueprint $table) {
      Severity: Minor
      Found in database/migrations/2019_09_07_150852_create_votes_table.php by phpmd

      ShortMethodName

      Since: 0.2

      Detects when very short method names are used.

      Example

      class ShortMethod {
    public function a( $index ) { // Violation
    }
}

      Source https://phpmd.org/rules/naming.html#shortmethodname

      Avoid using short method names like AlterCategoriesAddHidden::up(). The configured minimum method name length is 3.
      Open

          public function up()
    {
        Schema::table(
            'categories',
            function (Blueprint $table) {
      Severity: Minor
      Found in database/migrations/2017_08_03_144157_alter_categories_add_hidden.php by phpmd

      ShortMethodName

      Since: 0.2

      Detects when very short method names are used.

      Example

      class ShortMethod {
    public function a( $index ) { // Violation
    }
}

      Source https://phpmd.org/rules/naming.html#shortmethodname

      Avoid using short method names like AlterBadgeProjectAddStatus::up(). The configured minimum method name length is 3.
      Open

          public function up()
    {
        Schema::table(
            'badge_project',
            function (Blueprint $table) {
      Severity: Minor
      Found in database/migrations/2019_09_19_013757_alter_badge_project_add_status.php by phpmd

      ShortMethodName

      Since: 0.2

      Detects when very short method names are used.

      Example

      class ShortMethod {
    public function a( $index ) { // Violation
    }
}

      Source https://phpmd.org/rules/naming.html#shortmethodname

      Avoid using short method names like AlterVersionsMakeZipAndDependenciesNullable::up(). The configured minimum method name length is 3.
      Open

          public function up()
    {
        Schema::table(
            'versions',
            function (Blueprint $table) {
      Severity: Minor
      Found in database/migrations/2017_06_12_195025_alter_versions_make_zip_and_dependencies_nullable.php by phpmd

      ShortMethodName

      Since: 0.2

      Detects when very short method names are used.

      Example

      class ShortMethod {
    public function a( $index ) { // Violation
    }
}

      Source https://phpmd.org/rules/naming.html#shortmethodname

      Avoid using short method names like AlterUsersAddAdminBoolean::up(). The configured minimum method name length is 3.
      Open

          public function up()
    {
        Schema::table(
            'users',
            function (Blueprint $table) {
      Severity: Minor
      Found in database/migrations/2017_07_12_101551_alter_users_add_admin_boolean.php by phpmd

      ShortMethodName

      Since: 0.2

      Detects when very short method names are used.

      Example

      class ShortMethod {
    public function a( $index ) { // Violation
    }
}

      Source https://phpmd.org/rules/naming.html#shortmethodname

      Avoid using short method names like AddWebauthn::up(). The configured minimum method name length is 3.
      Open

          public function up()
    {
        Schema::create('webauthn_keys', function (Blueprint $table) {
            $table->increments('id');
            $table->integer('user_id')->unsigned();
      Severity: Minor
      Found in database/migrations/2019_03_29_163611_add_webauthn.php by phpmd

      ShortMethodName

      Since: 0.2

      Detects when very short method names are used.

      Example

      class ShortMethod {
    public function a( $index ) { // Violation
    }
}

      Source https://phpmd.org/rules/naming.html#shortmethodname

      Avoid using short method names like CreateFilesTable::up(). The configured minimum method name length is 3.
      Open

          public function up()
    {
        Schema::create(
            'files',
            function (Blueprint $table) {
      Severity: Minor
      Found in database/migrations/2017_06_12_141437_create_files_table.php by phpmd

      ShortMethodName

      Since: 0.2

      Detects when very short method names are used.

      Example

      class ShortMethod {
    public function a( $index ) { // Violation
    }
}

      Source https://phpmd.org/rules/naming.html#shortmethodname

      Avoid using short method names like AlterFilesAndVersionsAddUserId::up(). The configured minimum method name length is 3.
      Open

          public function up()
    {
        Schema::table(
            'versions',
            function (Blueprint $table) {
      Severity: Minor
      Found in database/migrations/2017_06_13_142609_alter_files_and_versions_add_user_id.php by phpmd

      ShortMethodName

      Since: 0.2

      Detects when very short method names are used.

      Example

      class ShortMethod {
    public function a( $index ) { // Violation
    }
}

      Source https://phpmd.org/rules/naming.html#shortmethodname

      Severity
      Category
      Status
      Source
      Language