balanced/rentmybikes-rails

View on GitHub

Showing 150 of 150 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if ( jQuery.isFunction( value ) ) {
            return this.each(function( j ) {
                jQuery( this ).removeClass( value.call( this, j, this.className ) );
            });
        }
public/assets/application-e688f6a6a31635feee665e7f52483711.js on lines 2078..2082

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function setOffset has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    setOffset: function( elem, options, i ) {
        var position = jQuery.css( elem, "position" );

        // set position first, in-case top/left are set even on static elem
        if ( position === "static" ) {
Severity: Minor
Found in public/assets/application-e688f6a6a31635feee665e7f52483711.js - About 1 hr to fix

    Function fixCloneNodeIssues has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function fixCloneNodeIssues( src, dest ) {
        var nodeName, e, data;
    
        // We do not need to do anything for non-Elements
        if ( dest.nodeType !== 1 ) {
    Severity: Minor
    Found in public/assets/application-e688f6a6a31635feee665e7f52483711.js - About 1 hr to fix

      Function load has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      jQuery.fn.load = function( url, params, callback ) {
          if ( typeof url !== "string" && _load ) {
              return _load.apply( this, arguments );
          }
      
      
      Severity: Minor
      Found in public/assets/application-e688f6a6a31635feee665e7f52483711.js - About 1 hr to fix

        Function attr has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            attr: function( elem, name, value ) {
                var hooks, notxml, ret,
                    nType = elem.nodeType;
        
                // don't get/set attributes on text, comment and attribute nodes
        Severity: Minor
        Found in public/assets/application-e688f6a6a31635feee665e7f52483711.js - About 1 hr to fix

          Function promise has 30 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          jQuery.ready.promise = function( obj ) {
              if ( !readyList ) {
          
                  readyList = jQuery.Deferred();
          
          
          Severity: Minor
          Found in public/assets/application-e688f6a6a31635feee665e7f52483711.js - About 1 hr to fix

            Function handlers has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                handlers: function( event, handlers ) {
                    var sel, handleObj, matches, i,
                        handlerQueue = [],
                        delegateCount = handlers.delegateCount,
                        cur = event.target;
            Severity: Minor
            Found in public/assets/application-e688f6a6a31635feee665e7f52483711.js - About 1 hr to fix

              Function html has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  html: function( value ) {
                      return jQuery.access( this, function( value ) {
                          var elem = this[0] || {},
                              i = 0,
                              l = this.length;
              Severity: Minor
              Found in public/assets/application-e688f6a6a31635feee665e7f52483711.js - About 1 hr to fix

                Function removeClass has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    removeClass: function( value ) {
                        var classes, elem, cur, clazz, j,
                            i = 0,
                            len = this.length,
                            proceed = arguments.length === 0 || typeof value === "string" && value;
                Severity: Minor
                Found in public/assets/application-e688f6a6a31635feee665e7f52483711.js - About 1 hr to fix

                  Function addClass has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      addClass: function( value ) {
                          var classes, elem, cur, clazz, j,
                              i = 0,
                              len = this.length,
                              proceed = typeof value === "string" && value;
                  Severity: Minor
                  Found in public/assets/application-e688f6a6a31635feee665e7f52483711.js - About 1 hr to fix

                    Function finish has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        finish: function( type ) {
                            if ( type !== false ) {
                                type = type || "fx";
                            }
                            return this.each(function() {
                    Severity: Minor
                    Found in public/assets/application-e688f6a6a31635feee665e7f52483711.js - About 1 hr to fix

                      Function fix has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          fix: function( event ) {
                              if ( event[ jQuery.expando ] ) {
                                  return event;
                              }
                      
                      
                      Severity: Minor
                      Found in public/assets/application-e688f6a6a31635feee665e7f52483711.js - About 1 hr to fix

                        Method rent has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                          def rent(params = {})
                            renter = params[:renter]
                            user = params[:user] || User.find_by(customer_href: renter.href)
                            user_id = user.nil? ? nil : user.id
                        
                        
                        Severity: Minor
                        Found in app/models/listing.rb - About 1 hr to fix

                          Function setup has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                                  setup: function() {
                          
                                      if ( rformElems.test( this.nodeName ) ) {
                                          // IE doesn't fire change on a check/radio until blur; trigger it on click
                                          // after a propertychange. Eat the blur-change in special.change.handle.
                          Severity: Minor
                          Found in public/assets/application-e688f6a6a31635feee665e7f52483711.js - About 1 hr to fix

                            Function propFilter has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                            function propFilter( props, specialEasing ) {
                                var value, name, index, easing, hooks;
                            
                                // camelCase, specialEasing and expand cssHook pass
                                for ( index in props ) {
                            Severity: Minor
                            Found in public/assets/application-e688f6a6a31635feee665e7f52483711.js - About 1 hr to fix

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                      if ( jQuery.isFunction( html ) ) {
                                          return this.each(function(i) {
                                              jQuery(this).wrapAll( html.call(this, i) );
                                          });
                                      }
                              public/assets/application-e688f6a6a31635feee665e7f52483711.js on lines 5914..5918

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 56.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Similar blocks of code found in 2 locations. Consider refactoring.
                              Open

                                      if ( jQuery.isFunction( html ) ) {
                                          return this.each(function(i) {
                                              jQuery(this).wrapInner( html.call(this, i) );
                                          });
                                      }
                              public/assets/application-e688f6a6a31635feee665e7f52483711.js on lines 5885..5889

                              Duplicated Code

                              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                              Tuning

                              This issue has a mass of 56.

                              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                              Refactorings

                              Further Reading

                              Function off has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                  off: function( types, selector, fn ) {
                                      var handleObj, type;
                                      if ( types && types.preventDefault && types.handleObj ) {
                                          // ( event )  dispatched jQuery.Event
                                          handleObj = types.handleObj;
                              Severity: Minor
                              Found in public/assets/application-e688f6a6a31635feee665e7f52483711.js - About 1 hr to fix

                                Function offset has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                                Open

                                jQuery.fn.offset = function( options ) {
                                    if ( arguments.length ) {
                                        return options === undefined ?
                                            this :
                                            this.each(function( i ) {
                                Severity: Minor
                                Found in public/assets/application-e688f6a6a31635feee665e7f52483711.js - About 1 hr to fix

                                  Consider simplifying this complex logical expression.
                                  Open

                                  if ( jQuery.expr && jQuery.expr.filters ) {
                                      jQuery.expr.filters.hidden = function( elem ) {
                                          // Support: Opera <= 12.12
                                          // Opera reports offsetWidths and offsetHeights less than zero on some elements
                                          return elem.offsetWidth <= 0 && elem.offsetHeight <= 0 ||
                                  Severity: Major
                                  Found in public/assets/application-e688f6a6a31635feee665e7f52483711.js - About 1 hr to fix
                                    Severity
                                    Category
                                    Status
                                    Source
                                    Language