balanced/rentmybikes-rails

View on GitHub

Showing 150 of 150 total issues

Consider simplifying this complex logical expression.
Open

                if ( unit !== "px" && start ) {
                    // Iteratively approximate from a nonzero starting point
                    // Prefer the current property, because this process will be trivial if it uses the same units
                    // Fallback to end or a simple constant
                    start = jQuery.css( tween.elem, prop, true ) || end || 1;
Severity: Major
Found in public/assets/application-e688f6a6a31635feee665e7f52483711.js - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            "odd": createPositionalPseudo(function( matchIndexes, length ) {
                var i = 1;
                for ( ; i < length; i += 2 ) {
                    matchIndexes.push( i );
                }
    Severity: Minor
    Found in public/assets/application-e688f6a6a31635feee665e7f52483711.js and 1 other location - About 55 mins to fix
    public/assets/application-e688f6a6a31635feee665e7f52483711.js on lines 4973..4979

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            "even": createPositionalPseudo(function( matchIndexes, length ) {
                var i = 0;
                for ( ; i < length; i += 2 ) {
                    matchIndexes.push( i );
                }
    Severity: Minor
    Found in public/assets/application-e688f6a6a31635feee665e7f52483711.js and 1 other location - About 55 mins to fix
    public/assets/application-e688f6a6a31635feee665e7f52483711.js on lines 4981..4987

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function access has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        access: function( elems, fn, key, value, chainable, emptyGet, raw ) {
    Severity: Major
    Found in public/assets/application-e688f6a6a31635feee665e7f52483711.js - About 50 mins to fix

      Avoid deeply nested control flow statements.
      Open

                                          if ( ofType ? node.nodeName.toLowerCase() === name : node.nodeType === 1 ) {
                                              return false;
                                          }
      Severity: Major
      Found in public/assets/application-e688f6a6a31635feee665e7f52483711.js - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                while ( j-- ) {
                                    if ( jQuery.nodeName( (tbody = elem.childNodes[j]), "tbody" ) && !tbody.childNodes.length ) {
                                        elem.removeChild( tbody );
                                    }
                                }
        Severity: Major
        Found in public/assets/application-e688f6a6a31635feee665e7f52483711.js - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                  for ( match in context ) {
                                      // Properties of context are called as methods if possible
                                      if ( jQuery.isFunction( this[ match ] ) ) {
                                          this[ match ]( context[ match ] );
          
          
          Severity: Major
          Found in public/assets/application-e688f6a6a31635feee665e7f52483711.js - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                if ( elem && elem.parentNode ) {
                                    // Handle the case where IE, Opera, and Webkit return items
                                    // by name instead of ID
                                    if ( elem.id === m ) {
                                        results.push( elem );
            Severity: Major
            Found in public/assets/application-e688f6a6a31635feee665e7f52483711.js - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                          if ( !xhrCallbacks ) {
                                              xhrCallbacks = {};
                                              jQuery( window ).unload( xhrOnUnloadAbort );
                                          }
              Severity: Major
              Found in public/assets/application-e688f6a6a31635feee665e7f52483711.js - About 45 mins to fix

                Function setMatcher has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                function setMatcher( preFilter, selector, matcher, postFilter, postFinder, postSelector ) {
                Severity: Minor
                Found in public/assets/application-e688f6a6a31635feee665e7f52483711.js - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                          if ( elem.id !== match[2] ) {
                                              return rootjQuery.find( selector );
                                          }
                  Severity: Major
                  Found in public/assets/application-e688f6a6a31635feee665e7f52483711.js - About 45 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                                                    if ( ( ofType ? node.nodeName.toLowerCase() === name : node.nodeType === 1 ) && ++diff ) {
                                                        // Cache the index of each encountered element
                                                        if ( useCache ) {
                                                            (node[ expando ] || (node[ expando ] = {}))[ type ] = [ dirruns, diff ];
                                                        }
                    Severity: Major
                    Found in public/assets/application-e688f6a6a31635feee665e7f52483711.js - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                                  if ( (data = cache[1]) === true || data === cachedruns ) {
                                                      return data === true;
                                                  }
                      Severity: Major
                      Found in public/assets/application-e688f6a6a31635feee665e7f52483711.js - About 45 mins to fix

                        Avoid deeply nested control flow statements.
                        Open

                                            for ( conv2 in converters ) {
                        
                                                // If conv2 outputs current
                                                tmp = conv2.split(" ");
                                                if ( tmp[ 1 ] === current ) {
                        Severity: Major
                        Found in public/assets/application-e688f6a6a31635feee665e7f52483711.js - About 45 mins to fix

                          Avoid deeply nested control flow statements.
                          Open

                                              if ( conv && s["throws"] ) {
                                                  response = conv( response );
                                              } else {
                                                  try {
                                                      response = conv( response );
                          Severity: Major
                          Found in public/assets/application-e688f6a6a31635feee665e7f52483711.js - About 45 mins to fix

                            Avoid deeply nested control flow statements.
                            Open

                                            } else if ( copy !== undefined ) {
                                                target[ name ] = copy;
                                            }
                            Severity: Major
                            Found in public/assets/application-e688f6a6a31635feee665e7f52483711.js - About 45 mins to fix

                              Avoid deeply nested control flow statements.
                              Open

                                                          if ( cache[1] === true ) {
                                                              return true;
                                                          }
                              Severity: Major
                              Found in public/assets/application-e688f6a6a31635feee665e7f52483711.js - About 45 mins to fix

                                Avoid deeply nested control flow statements.
                                Open

                                                    if ( copyIsArray ) {
                                                        copyIsArray = false;
                                                        clone = src && jQuery.isArray(src) ? src : [];
                                
                                                    } else {
                                Severity: Major
                                Found in public/assets/application-e688f6a6a31635feee665e7f52483711.js - About 45 mins to fix

                                  Avoid deeply nested control flow statements.
                                  Open

                                                          while ( cur.indexOf( " " + clazz + " " ) >= 0 ) {
                                                              cur = cur.replace( " " + clazz + " ", " " );
                                                          }
                                  Severity: Major
                                  Found in public/assets/application-e688f6a6a31635feee665e7f52483711.js - About 45 mins to fix

                                    Avoid deeply nested control flow statements.
                                    Open

                                                            for ( type in data.events ) {
                                                                if ( special[ type ] ) {
                                                                    jQuery.event.remove( elem, type );
                                    
                                                                // This is a shortcut to avoid jQuery.event.remove's overhead
                                    Severity: Major
                                    Found in public/assets/application-e688f6a6a31635feee665e7f52483711.js - About 45 mins to fix
                                      Severity
                                      Category
                                      Status
                                      Source
                                      Language