Sign upLogin

barracudanetworks/jobrunner

View on GitHub
Star
src/JobRunner.php

Summary

Maintainability
B
6 hrs
Test Coverage

Function canJobRun has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    protected function canJobRun($class)
    {
        $job_definition = $this->jobs[$class];
        if ($job_definition->getEnabled() == false)
        {
Severity: Minor
Found in src/JobRunner.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method canJobRun has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function canJobRun($class)
    {
        $job_definition = $this->jobs[$class];
        if ($job_definition->getEnabled() == false)
        {
Severity: Minor
Found in src/JobRunner.php - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

                    return true;
    Severity: Major
    Found in src/JobRunner.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return false;
      Severity: Major
      Found in src/JobRunner.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return false;
        Severity: Major
        Found in src/JobRunner.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return true;
          Severity: Major
          Found in src/JobRunner.php - About 30 mins to fix

            Missing class doc comment
            Open

            class JobRunner
            Severity: Minor
            Found in src/JobRunner.php by phpcodesniffer

            Expected 1 spaces after parameter type; 8 found
            Open

                 * @param string        $class          The job that finished.
            Severity: Minor
            Found in src/JobRunner.php by phpcodesniffer

            Expected 1 spaces after parameter type; 2 found
            Open

                 * @param JobDefinition  $definition Job definition (e.g. interval).
            Severity: Minor
            Found in src/JobRunner.php by phpcodesniffer

            Missing file doc comment
            Open
            Severity: Minor
            Found in src/JobRunner.php by phpcodesniffer

            Expected 1 spaces after parameter type; 9 found
            Open

                 * @param string         $class          The job to check.
            Severity: Minor
            Found in src/JobRunner.php by phpcodesniffer

            Expected 1 spaces after parameter name; 10 found
            Open

                 * @param string        $class          The job that finished.
            Severity: Minor
            Found in src/JobRunner.php by phpcodesniffer

            Function closing brace must go on the next line following the body; found 1 blank lines before brace
            Open

                }
            Severity: Minor
            Found in src/JobRunner.php by phpcodesniffer

            Expected 1 spaces after parameter name; 10 found
            Open

                 * @param string         $class          The job to check.
            Severity: Minor
            Found in src/JobRunner.php by phpcodesniffer

            There are no issues that match your filters.

            Category
            Status