Sign upLogin

basestylo/Tweakphoeus

View on GitHub
Star
lib/tweakphoeus/cookie_jar.rb

Summary

Maintainability
A
0 mins
Test Coverage

Tweakphoeus::CookieJar#parse_cookie has approx 6 statements
Open

    def parse_cookie(string)
Severity: Minor
Found in lib/tweakphoeus/cookie_jar.rb by reek

A method with Too Many Statements is any method that has a large number of lines.

Too Many Statements warns about any method that has more than 5 statements. Reek's smell detector for Too Many Statements counts +1 for every simple statement in a method and +1 for every statement within a control structure (if, else, case, when, for, while, until, begin, rescue) but it doesn't count the control structure itself.

So the following method would score +6 in Reek's statement-counting algorithm:

def parse(arg, argv, &error)
  if !(val = arg) and (argv.empty? or /\A-/ =~ (val = argv[0]))
    return nil, block, nil                                         # +1
  end
  opt = (val = parse_arg(val, &error))[1]                          # +2
  val = conv_arg(*val)                                             # +3
  if opt and !arg
    argv.shift                                                     # +4
  else
    val[0] = nil                                                   # +5
  end
  val                                                              # +6
end

(You might argue that the two assigments within the first @if@ should count as statements, and that perhaps the nested assignment should count as +2.)

Tweakphoeus::CookieJar#cookie_string has approx 8 statements
Open

    def cookie_string(url, headers = {})
Severity: Minor
Found in lib/tweakphoeus/cookie_jar.rb by reek

A method with Too Many Statements is any method that has a large number of lines.

Too Many Statements warns about any method that has more than 5 statements. Reek's smell detector for Too Many Statements counts +1 for every simple statement in a method and +1 for every statement within a control structure (if, else, case, when, for, while, until, begin, rescue) but it doesn't count the control structure itself.

So the following method would score +6 in Reek's statement-counting algorithm:

def parse(arg, argv, &error)
  if !(val = arg) and (argv.empty? or /\A-/ =~ (val = argv[0]))
    return nil, block, nil                                         # +1
  end
  opt = (val = parse_arg(val, &error))[1]                          # +2
  val = conv_arg(*val)                                             # +3
  if opt and !arg
    argv.shift                                                     # +4
  else
    val[0] = nil                                                   # +5
  end
  val                                                              # +6
end

(You might argue that the two assigments within the first @if@ should count as statements, and that perhaps the nested assignment should count as +2.)

Tweakphoeus::CookieJar#obtain_cookies has approx 6 statements
Open

    def obtain_cookies(response)
Severity: Minor
Found in lib/tweakphoeus/cookie_jar.rb by reek

A method with Too Many Statements is any method that has a large number of lines.

Too Many Statements warns about any method that has more than 5 statements. Reek's smell detector for Too Many Statements counts +1 for every simple statement in a method and +1 for every statement within a control structure (if, else, case, when, for, while, until, begin, rescue) but it doesn't count the control structure itself.

So the following method would score +6 in Reek's statement-counting algorithm:

def parse(arg, argv, &error)
  if !(val = arg) and (argv.empty? or /\A-/ =~ (val = argv[0]))
    return nil, block, nil                                         # +1
  end
  opt = (val = parse_arg(val, &error))[1]                          # +2
  val = conv_arg(*val)                                             # +3
  if opt and !arg
    argv.shift                                                     # +4
  else
    val[0] = nil                                                   # +5
  end
  val                                                              # +6
end

(You might argue that the two assigments within the first @if@ should count as statements, and that perhaps the nested assignment should count as +2.)

Complex method Tweakphoeus::CookieJar#obtain_cookies (23.9)
Open

    def obtain_cookies(response)
      set_cookies_field = [response.headers['Set-Cookie']].compact

      set_cookies_field.each do |cookie|
        key, value = cookie.match(/^([^=]+)=(.+)/).to_a[1..]
Severity: Minor
Found in lib/tweakphoeus/cookie_jar.rb by flog

Flog calculates the ABC score for methods. The ABC score is based on assignments, branches (method calls), and conditions.

You can read more about ABC metrics or the flog tool

Tweakphoeus::CookieJar#set_cookie calls '@cookie_jar[domain]' 3 times
Open

      @cookie_jar[domain] ||= {}

      value = value.split(';').first

      if value == '""'
Severity: Minor
Found in lib/tweakphoeus/cookie_jar.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

Tweakphoeus::CookieJar#add_cookies calls '@cookie_jar[domain]' 2 times
Open

      @cookie_jar[domain] ||= {}
      @cookie_jar[domain][key] = value
Severity: Minor
Found in lib/tweakphoeus/cookie_jar.rb by reek

Duplication occurs when two fragments of code look nearly identical, or when two fragments of code have nearly identical effects at some conceptual level.

Reek implements a check for Duplicate Method Call.

Example

Here's a very much simplified and contrived example. The following method will report a warning:

def double_thing()
  @other.thing + @other.thing
end

One quick approach to silence Reek would be to refactor the code thus:

def double_thing()
  thing = @other.thing
  thing + thing
end

A slightly different approach would be to replace all calls of double_thing by calls to @other.double_thing:

class Other
  def double_thing()
    thing + thing
  end
end

The approach you take will depend on balancing other factors in your code.

Tweakphoeus::CookieJar#parse_cookie doesn't depend on instance state (maybe move it to another class?)
Open

    def parse_cookie(string)
Severity: Minor
Found in lib/tweakphoeus/cookie_jar.rb by reek

A Utility Function is any instance method that has no dependency on the state of the instance.

Tweakphoeus::CookieJar#purge_bad_cookies doesn't depend on instance state (maybe move it to another class?)
Open

    def purge_bad_cookies(cookies)
Severity: Minor
Found in lib/tweakphoeus/cookie_jar.rb by reek

A Utility Function is any instance method that has no dependency on the state of the instance.

There are no issues that match your filters.

Category
Status