bbc/simorgh

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    describe(
      'Video Player',
      {
        retries: 3,
      },

• Read up
  Read up

File buildParams.test.ts has 1067 lines of code (exceeds 250 allowed). Consider refactoring.

Open

import { TOPIC_PAGE } from '#app/routes/utils/pageTypes';
import * as analyticsUtils from '#lib/analyticsUtils';
import { RequestContextProps } from '../../../../contexts/RequestContext';
import { ServiceConfig } from '../../../../models/types/serviceConfig';
import { buildPageATIParams, buildPageATIUrl } from './buildParams';

Similar blocks of code found in 3 locations. Consider refactoring.

Open

  {
    id: '917068ee',
    type: 'link',
    model: {
      locator: 'urn:bbc:cps:curie:asset:b5c53243-a695-e059-e040-850a02846523',

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

  {
    id: '9f20a126',
    type: 'link',
    model: {
      locator: 'urn:bbc:content:url-promo:https%3A%2F%2Fwww.bbc.co.uk%2Fpidgin',

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

  {
    id: 'ba2f138e',
    type: 'link',
    model: {
      locator: 'urn:bbc:content:url-promo:https%3A%2F%2Fwww.bbc.co.uk%2Fmundo',

• Read up
  Read up

Similar blocks of code found in 7 locations. Consider refactoring.

Open

test('from', () => {
  const start = moment([2007, 1, 28]);
  assert.equal(
    start.from(moment([2007, 1, 28]).add({ s: 45 }), true),
    'ከ 1 ደቂቃ',

• Read up
  Read up

Similar blocks of code found in 7 locations. Consider refactoring.

Open

test('from', () => {
  const start = moment([2007, 1, 28]);

  assert.equal(
    start.from(moment([2007, 1, 28]).add({ s: 45 }), true),

• Read up
  Read up

Similar blocks of code found in 7 locations. Consider refactoring.

Open

test('from', () => {
  const start = moment([2007, 1, 28]);

  assert.equal(
    start.from(moment([2007, 1, 28]).add({ s: 45 }), true),

• Read up
  Read up

Similar blocks of code found in 7 locations. Consider refactoring.

Open

test('from', () => {
  const start = moment([2007, 1, 28]);
  assert.equal(
    start.from(moment([2007, 1, 28]).add({ s: 45 }), true),
    'Daqiiqaa 1',

• Read up
  Read up

Similar blocks of code found in 7 locations. Consider refactoring.

Open

test('from', () => {
  const start = moment([2007, 1, 28]);

  assert.equal(
    start.from(moment([2007, 1, 28]).add({ s: 45 }), true),

• Read up
  Read up

Similar blocks of code found in 7 locations. Consider refactoring.

Open

test('from', () => {
  const start = moment([2007, 1, 28]);

  assert.equal(
    start.from(moment([2007, 1, 28]).add({ s: 45 }), true),

• Read up
  Read up

Similar blocks of code found in 7 locations. Consider refactoring.

Open

test('from', () => {
  const start = moment([2007, 1, 28]);
  assert.equal(
    start.from(moment([2007, 1, 28]).add({ s: 45 }), true),
    '۱ دقیقه',

• Read up
  Read up

File index.test.tsx has 976 lines of code (exceeds 250 allowed). Consider refactoring.

Open

/* eslint-disable no-template-curly-in-string */
import React from 'react';
import { articleDataNews } from '#pages/ArticlePage/fixtureData';
import mapAssetData from '#pages/MediaAssetPage/fixtureData.json';
import pglAssetData from '#pages/PhotoGalleryPage/fixtureData.json';

Identical blocks of code found in 2 locations. Consider refactoring.

Open

export default () => {
  it('I can see the brand title', () => {
    const brandTitleEl = document.querySelector('h1 span span:first-child');

    expect(brandTitleEl).toBeInTheDocument();

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

export default () => {
  it('I can see the brand title', () => {
    const brandTitleEl = document.querySelector('h1 span span:first-child');

    expect(brandTitleEl).toBeInTheDocument();

• Read up
  Read up

File fixtureData.jsx has 966 lines of code (exceeds 250 allowed). Consider refactoring.

Open

import React from 'react';
import { BrowserRouter } from 'react-router-dom';
import { singleTextBlock } from '#models/blocks';
import { RequestContextProvider } from '#contexts/RequestContext';
import { ARTICLE_PAGE, LIVE_PAGE } from '#app/routes/utils/pageTypes';

File index.test.tsx has 947 lines of code (exceeds 250 allowed). Consider refactoring.

Open

import React from 'react';
import { Helmet } from 'react-helmet';
import {
  ARTICLE_PAGE,
  FRONT_PAGE,

Similar blocks of code found in 2 locations. Consider refactoring.

Open

export const bylineWithNoAuthor = [
  {
    type: 'contributor',
    model: {
      topicId: '',

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

export const bylineWithNoRole = [
  {
    type: 'contributor',
    model: {
      topicId: '',

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  describe(`Images`, () => {
    it('should have a picture tag around images', () => {
      cy.get('img').each($img => {
        const $section = $img.parents('section');
        if ($section.length > 0) {

• Read up
  Read up