Sign upLogin

bbyars/mountebank

View on GitHub
Star

Showing 386 of 386 total issues

Function create has 130 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function create () {
    function hasExactlyOneKey (obj) {
        const keys = Object.keys(obj);
        return keys.length === 1;
    }
Severity: Major
Found in src/models/behaviorsValidator.js - About 5 hrs to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                if (socket.on) {
                connections[name] = socket;

                socket.on('error', error => {
                    logger.error('%s transmission error X=> %s', name, JSON.stringify(error));
    Severity: Major
    Found in src/models/http/baseHttpServer.js and 1 other location - About 4 hrs to fix
    src/models/smtp/smtpServer.js on lines 25..40

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 128.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

                    if (socket.on) {
                    connections[name] = socket;

                    socket.on('error', error => {
                        logger.error('%s transmission error X=> %s', name, JSON.stringify(error));
    Severity: Major
    Found in src/models/smtp/smtpServer.js and 1 other location - About 4 hrs to fix
    src/models/http/baseHttpServer.js on lines 103..118

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 128.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function create has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
    Open

    function create (logger) {
    const BINARY_CONTENT_ENCODINGS = [
        'gzip', 'br', 'compress', 'deflate'
    ];
    const BINARY_MIME_TYPES = [
    Severity: Minor
    Found in src/models/http/httpProxy.js - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function create has 107 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function create (options, logger, responseFn) {
    const mode = options.mode ? options.mode : 'text',
        encoding = mode === 'binary' ? 'base64' : 'utf8',
        server = net.createServer(),
        connections = {},
    Severity: Major
    Found in src/models/tcp/tcpServer.js - About 4 hrs to fix

      Function createApp has 106 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      async function createApp (options) {
    applyDefaults(options);

    const app = express(),
        hostname = options.host || 'localhost',
      Severity: Major
      Found in src/mountebank.js - About 4 hrs to fix

        Function outOfProcessCreate has 100 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            function outOfProcessCreate (protocolName, config) {
        function customFieldsFor (creationRequest) {
            const fields = {},
                commonFields = ['protocol', 'port', 'name', 'recordRequests', 'stubs', 'defaultResponse'];
            Object.keys(creationRequest).forEach(key => {
        Severity: Major
        Found in src/models/protocols.js - About 4 hrs to fix

          File predicates.js has 331 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          'use strict';

const stringify = require('safe-stable-stringify'),
    safeRegex = require('safe-regex'),
    jsonpath = require('./jsonpath.js'),
          Severity: Minor
          Found in src/models/predicates.js - About 3 hrs to fix

            Function create has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
            Open

            function create () {
    function hasExactlyOneKey (obj) {
        const keys = Object.keys(obj);
        return keys.length === 1;
    }
            Severity: Minor
            Found in src/models/behaviorsValidator.js - About 3 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function create has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
            Open

            function create (protocols, imposters, logger, allowInjection) {
    function isFlagFalse (query, key) {
        return !helpers.defined(query[key]) || query[key].toLowerCase() !== 'false';
    }
            Severity: Minor
            Found in src/controllers/impostersController.js - About 3 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function create has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
            Open

            function create (header, server, loadRequests) {
    const baseURL = `/imposters/${server.port}`;

    function createHeader (numberOfRequests, options) {
        const result = {
            Severity: Minor
            Found in src/models/imposterPrinter.js - About 3 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function exports has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
            Open

            module.exports = function (createBaseServer) {

    function create (options, logger, responseFn) {
        const connections = {},
            defaultResponse = options.defaultResponse || {};
            Severity: Minor
            Found in src/models/http/baseHttpServer.js - About 3 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function createStubsRepository has 89 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            function createStubsRepository () {
    const stubs = [];
    let requests = [];

    function reindex () {
            Severity: Major
            Found in src/models/inMemoryImpostersRepository.js - About 3 hrs to fix

              Function create has 87 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function create (header, server, loadRequests) {
    const baseURL = `/imposters/${server.port}`;

    function createHeader (numberOfRequests, options) {
        const result = {
              Severity: Major
              Found in src/models/imposterPrinter.js - About 3 hrs to fix

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                            server.on('error', error => {
                if (error.errno === 'EADDRINUSE') {
                    reject(errors.ResourceConflictError(`Port ${options.port} is already in use`));
                }
                else if (error.errno === 'EACCES') {
                Severity: Major
                Found in src/models/http/baseHttpServer.js and 1 other location - About 3 hrs to fix
                src/models/tcp/tcpServer.js on lines 120..130

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 104.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                        server.on('error', error => {
            if (error.errno === 'EADDRINUSE') {
                reject(errors.ResourceConflictError(`Port ${options.port} is already in use`));
            }
            else if (error.errno === 'EACCES') {
                Severity: Major
                Found in src/models/tcp/tcpServer.js and 1 other location - About 3 hrs to fix
                src/models/http/baseHttpServer.js on lines 159..169

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 104.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                File responseResolver.js has 302 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                'use strict';

const prometheus = require('prom-client'),
    stringify = require('safe-stable-stringify'),
    helpers = require('../util/helpers.js'),
                Severity: Minor
                Found in src/models/responseResolver.js - About 3 hrs to fix

                  Function create has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
                  Open

                  function create (options, logger, responseFn) {
    const mode = options.mode ? options.mode : 'text',
        encoding = mode === 'binary' ? 'base64' : 'utf8',
        server = net.createServer(),
        connections = {},
                  Severity: Minor
                  Found in src/models/tcp/tcpServer.js - About 3 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function create has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
                  Open

                  async function create (Protocol, creationRequest, baseLogger, config, isAllowedConnection) {

    const metrics = getMetrics();

    function scopeFor (port) {
                  Severity: Minor
                  Found in src/models/imposter.js - About 3 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function create has 74 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  function create (options, logger, responseFn) {
    const connections = {},
        SMTPServer = smtpServer.SMTPServer,
        server = new SMTPServer({
            maxAllowedUnauthenticatedCommands: 1000,
                  Severity: Major
                  Found in src/models/smtp/smtpServer.js - About 2 hrs to fix
                    Severity
                    Category
                    Status
                    Source
                    Language