Sign upLogin

bcdice/BCDice

View on GitHub
Star

Showing 1,176 of 1,233 total issues

Method getFumbleTypeAndTable has 75 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def getFumbleTypeAndTable(head)
        case head
        when "S"
          type = '射撃'
          # 射撃ファンブル表
Severity: Major
Found in lib/bcdice/game_system/GundogZero.rb - About 3 hrs to fix

    File Torg.rb has 291 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    module BCDice
  module GameSystem
    class Torg < Base
      # ゲームシステムの識別子
      ID = 'Torg'
    Severity: Minor
    Found in lib/bcdice/game_system/Torg.rb - About 3 hrs to fix

      File Satasupe.rb has 291 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      require "bcdice/game_system/satasupe/tables"

module BCDice
  module GameSystem
    class Satasupe < Base
      Severity: Minor
      Found in lib/bcdice/game_system/Satasupe.rb - About 3 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              NAME2 = DiceTable::Table.new(
        "名字表",
        "1D100",
        [
          'アラタ/聖', # 1
        Severity: Major
        Found in lib/bcdice/game_system/TrinitySeven.rb and 1 other location - About 3 hrs to fix
        lib/bcdice/game_system/TrinitySeven.rb on lines 148..252

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 107.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              NAME1 = DiceTable::Table.new(
        "名字表",
        "1D100",
        [
          '春日', # 1
        Severity: Major
        Found in lib/bcdice/game_system/TrinitySeven.rb and 1 other location - About 3 hrs to fix
        lib/bcdice/game_system/TrinitySeven.rb on lines 255..359

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 107.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method roll_amadeus has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
        Open

              def roll_amadeus(command)
        m = /^R([A-DS])([+\-\d]*)(@(\d))?((>=?)([+\-\d]*))?(@(\d))?$/i.match(command)
        unless m
          return nil
        end
        Severity: Minor
        Found in lib/bcdice/game_system/Amadeus.rb - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              PHOBIAS_TABLE = [
        '入浴恐怖症：体、手、顔を洗うのが怖い。',
        '高所恐怖症：高いところが怖い。',
        '飛行恐怖症：飛ぶのが怖い。',
        '広場恐怖症：広場、公共の(混雑した)場所が怖い。',
        Severity: Major
        Found in lib/bcdice/game_system/Cthulhu7th.rb and 1 other location - About 2 hrs to fix
        lib/bcdice/game_system/Cthulhu7th.rb on lines 448..549

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 103.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              MANIAS_TABLE = [
        '洗浄マニア：自分の体を洗わずにはいられない。',
        '無為マニア：病的な優柔不断。',
        '暗闇マニア：暗黒に関する過度の嗜好。',
        '高所マニア：高い場所に登らずにはいられない。',
        Severity: Major
        Found in lib/bcdice/game_system/Cthulhu7th.rb and 1 other location - About 2 hrs to fix
        lib/bcdice/game_system/Cthulhu7th.rb on lines 344..445

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 103.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        File Warhammer4.rb has 284 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        module BCDice
  module GameSystem
    class Warhammer4 < Base
      # ゲームシステムの識別子
      ID = 'Warhammer4'
        Severity: Minor
        Found in lib/bcdice/game_system/Warhammer4.rb - About 2 hrs to fix

          Method attack_roll has 70 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                def attack_roll(command)
        m = /^AT([-+]\d+)?(@(\d+))?(>=(\d+))?([AD]?)/.match(command)
        unless m
          return nil
        end
          Severity: Major
          Found in lib/bcdice/game_system/DungeonsAndDragons5.rb - About 2 hrs to fix

            Method checkRoll has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
            Open

                  def checkRoll(rapid, target, damage, isCritical, criticalNumber)
        totalSuccessCount = 0
        totalCriticalCount = 0
        text = ""
            Severity: Minor
            Found in lib/bcdice/game_system/Alsetto.rb - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method eval_game_system_specific_command has 68 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                  def eval_game_system_specific_command(string)
        unless parse_ars(string) || parse_1r10(string)
          return nil
        end
            Severity: Major
            Found in lib/bcdice/game_system/ArsMagica.rb - About 2 hrs to fix

              Method mh_crc_table has 68 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                    def mh_crc_table(suv, num)
        header_parts = ['戦闘結果チャート', num]
        separator = ' ＞ '

        suv = suv.to_s.upcase
              Severity: Major
              Found in lib/bcdice/game_system/MetalHead.rb - About 2 hrs to fix

                Method rating has 68 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                      def rating(string) # レーティング表
        debug("rating string", string)
        command = rating_parser.parse(string)

        unless command
                Severity: Major
                Found in lib/bcdice/game_system/SwordWorld.rb - About 2 hrs to fix

                  File Cthulhu7th_ChineseTraditional.rb has 279 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  module BCDice
  module GameSystem
    class Cthulhu7th_ChineseTraditional < Base
      # ゲームシステムの識別子
      ID = 'Cthulhu7th:ChineseTraditional'
                  Severity: Minor
                  Found in lib/bcdice/game_system/Cthulhu7th_ChineseTraditional.rb - About 2 hrs to fix

                    File SkynautsBouken.rb has 278 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    module BCDice
  module GameSystem
    class SkynautsBouken < Base
      # ゲームシステムの識別子
      ID = 'SkynautsBouken'
                    Severity: Minor
                    Found in lib/bcdice/game_system/SkynautsBouken.rb - About 2 hrs to fix

                      File Cthulhu7th_Korean.rb has 277 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      module BCDice
  module GameSystem
    class Cthulhu7th_Korean < Base
      # ゲームシステムの識別子
      ID = 'Cthulhu7th:Korean'
                      Severity: Minor
                      Found in lib/bcdice/game_system/Cthulhu7th_Korean.rb - About 2 hrs to fix

                        File ShuumatsuKikou.rb has 277 lines of code (exceeds 250 allowed). Consider refactoring.
                        Open

                        module BCDice
  module GameSystem
    class ShuumatsuKikou < Base
      # ゲームシステムの識別子
      ID = 'ShuumatsuKikou'
                        Severity: Minor
                        Found in lib/bcdice/game_system/ShuumatsuKikou.rb - About 2 hrs to fix

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                def getFumbleTypeAndTable(head)
        case head
        when "S"
          type = '射撃'
          # 射撃ファンブル表
                          Severity: Major
                          Found in lib/bcdice/game_system/GundogZero.rb and 1 other location - About 2 hrs to fix
                          lib/bcdice/game_system/GundogRevised.rb on lines 212..291

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 96.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                def getFumbleTypeAndTable(head)
        case head
        when "S"
          type = '射撃'
          # 射撃ファンブル表
                          Severity: Major
                          Found in lib/bcdice/game_system/GundogRevised.rb and 1 other location - About 2 hrs to fix
                          lib/bcdice/game_system/GundogZero.rb on lines 178..257

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 96.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Severity
                          Category
                          Status
                          Source
                          Language