Sign upLogin

bcdice/BCDice

View on GitHub
Star
lib/bcdice/game_system/meikyu_kingdom/item_table.rb

Summary

Maintainability
D
2 days
Test Coverage
A
95%

File item_table.rb has 336 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module BCDice
  module GameSystem
    class MeikyuKingdom
      # デバイスファクトリー(1D6)
      def mk_device_factory_table()
Severity: Minor
Found in lib/bcdice/game_system/meikyu_kingdom/item_table.rb - About 4 hrs to fix

    Method mk_item_features_table has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

          def mk_item_features_table(num)
        output = ""
        dice = @randomizer.roll_sum(2, 6)

        if num <= 2
    Severity: Minor
    Found in lib/bcdice/game_system/meikyu_kingdom/item_table.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method mk_rare_item_table has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def mk_rare_item_table(num)
        table = [
          [11, "ブルーリボン"],
          [12, "聖痕"],
          [13, "剥製"],
    Severity: Minor
    Found in lib/bcdice/game_system/meikyu_kingdom/item_table.rb - About 1 hr to fix

      Method mk_rare_weapon_item_table has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def mk_rare_weapon_item_table(num)
        table = [
          [11, "虚弾"],
          [12, "怪物毒"],
          [13, "小鬼の襟巻"],
      Severity: Minor
      Found in lib/bcdice/game_system/meikyu_kingdom/item_table.rb - About 1 hr to fix

        Method mk_item_features_table has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def mk_item_features_table(num)
        output = ""
        dice = @randomizer.roll_sum(2, 6)

        if num <= 2
        Severity: Minor
        Found in lib/bcdice/game_system/meikyu_kingdom/item_table.rb - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                def mk_rare_item_table(num)
        table = [
          [11, "ブルーリボン"],
          [12, "聖痕"],
          [13, "剥製"],
          Severity: Major
          Found in lib/bcdice/game_system/meikyu_kingdom/item_table.rb and 1 other location - About 3 hrs to fix
          lib/bcdice/game_system/meikyu_kingdom/item_table.rb on lines 145..185

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 116.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                def mk_rare_weapon_item_table(num)
        table = [
          [11, "虚弾"],
          [12, "怪物毒"],
          [13, "小鬼の襟巻"],
          Severity: Major
          Found in lib/bcdice/game_system/meikyu_kingdom/item_table.rb and 1 other location - About 3 hrs to fix
          lib/bcdice/game_system/meikyu_kingdom/item_table.rb on lines 189..229

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 116.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  table = [
          [2, "モンスタースキル"],
          [3, "便利スキル"],
          [4, "芸能スキル"],
          [5, "迷宮スキル"],
          Severity: Minor
          Found in lib/bcdice/game_system/meikyu_kingdom/item_table.rb and 2 other locations - About 35 mins to fix
          lib/bcdice/game_system/Postman.rb on lines 131..143
          lib/bcdice/game_system/Postman.rb on lines 163..175

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 35.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                def mk_item_jyuka_table(num)
        table = [
          [1, "「呪い」のバッドステータス"],
          [2, "「肥満」のバッドステータス"],
          [3, "「愚か」のバッドステータス"],
          Severity: Minor
          Found in lib/bcdice/game_system/meikyu_kingdom/item_table.rb and 2 other locations - About 25 mins to fix
          lib/bcdice/game_system/meikyu_kingdom/item_table.rb on lines 269..279
          lib/bcdice/game_system/meikyu_kingdom/item_table.rb on lines 330..340

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 31.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                def mk_item_power_table(num)
        table = [
          [1, "〔才覚〕"],
          [2, "〔魅力〕"],
          [3, "〔探索〕"],
          Severity: Minor
          Found in lib/bcdice/game_system/meikyu_kingdom/item_table.rb and 2 other locations - About 25 mins to fix
          lib/bcdice/game_system/meikyu_kingdom/item_table.rb on lines 302..312
          lib/bcdice/game_system/meikyu_kingdom/item_table.rb on lines 330..340

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 31.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                def mk_item_attribute_table(num)
        table = [
          [1, "自然の力"],
          [2, "幻夢の力"],
          [3, "星炎の力"],
          Severity: Minor
          Found in lib/bcdice/game_system/meikyu_kingdom/item_table.rb and 2 other locations - About 25 mins to fix
          lib/bcdice/game_system/meikyu_kingdom/item_table.rb on lines 269..279
          lib/bcdice/game_system/meikyu_kingdom/item_table.rb on lines 302..312

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 31.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status