app/src/components/custom/tables/RequestsTable.tsx
Function RequestsTable has 524 lines of code (exceeds 150 allowed). Consider refactoring. Open
Open
const RequestsTable = (props: RequestTableProps) => {
const { data: propData } = props;
const [data, setData] = useState<Array<ReimbursementRequest>>(propData); // Main data state
const selectItems = [
RequestStates.INCOMPLETE,Function RequestsTable has a Cognitive Complexity of 82 (exceeds 5 allowed). Consider refactoring. Open
Open
const RequestsTable = (props: RequestTableProps) => {
const { data: propData } = props;
const [data, setData] = useState<Array<ReimbursementRequest>>(propData); // Main data state
const selectItems = [
RequestStates.INCOMPLETE,- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File RequestsTable.tsx has 589 lines of code (exceeds 500 allowed). Consider refactoring. Confirmed
Confirmed
import {
Table,
TableBody,
TableContainer,
TableHead,Avoid too many return statements within this function. Open
Open
return data.sort((a, b) => a.submissionDate.localeCompare(b.submissionDate));Avoid too many return statements within this function. Open
Open
return data.sort((a, b) =>
convertStateToStatus(b.state).localeCompare(convertStateToStatus(a.state)),
);Avoid too many return statements within this function. Open
Open
return false;Avoid too many return statements within this function. Open
Open
return data; // Should already be sorted descending from API.Avoid too many return statements within this function. Open
Open
return data.sort((a, b) =>
convertStateToStatus(a.state).localeCompare(convertStateToStatus(b.state)),
);