Sign upLogin

bcgov/citz-imb-staff-purchasing-reimbursement

View on GitHub
Star

Showing 34 of 45 total issues

Function RequestsTable has 524 lines of code (exceeds 150 allowed). Consider refactoring.
Open

const RequestsTable = (props: RequestTableProps) => {
  const { data: propData } = props;
  const [data, setData] = useState<Array<ReimbursementRequest>>(propData); // Main data state
  const selectItems = [
    RequestStates.INCOMPLETE,
Severity: Major
Found in app/src/components/custom/tables/RequestsTable.tsx - About 1 day to fix

    Function RequestsTable has a Cognitive Complexity of 82 (exceeds 5 allowed). Consider refactoring.
    Open

    const RequestsTable = (props: RequestTableProps) => {
  const { data: propData } = props;
  const [data, setData] = useState<Array<ReimbursementRequest>>(propData); // Main data state
  const selectItems = [
    RequestStates.INCOMPLETE,
    Severity: Minor
    Found in app/src/components/custom/tables/RequestsTable.tsx - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function RequestForm has 390 lines of code (exceeds 150 allowed). Consider refactoring.
    Open

    const RequestForm = (props: RequestFormProps) => {
  const {
    locked,
    isAdmin,
    handleUpdate,
    Severity: Major
    Found in app/src/components/custom/forms/RequestForm.tsx - About 1 day to fix

      Function updateRequestState has a Cognitive Complexity of 52 (exceeds 5 allowed). Consider refactoring.
      Open

      export const updateRequestState = async (req: Request, res: Response) => {
  const { id } = req.params;
  const { employeeId, purchases, approvals, additionalComments, state, isAdmin } = req.body;
  const { TESTING, FRONTEND_URL } = Constants;
  const { GC_NOTIFY_ADMIN_EMAIL } = process.env;
      Severity: Minor
      Found in api/controllers/requests-api-controller.ts - About 1 day to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      const chefRequestSchema = z
  .object({
    lateEntry: z.boolean().optional(),
    idir: z.string().length(32),
    firstName: nameSchema,
      Severity: Major
      Found in app/src/schemas/chefRequestSchema.ts and 1 other location - About 6 hrs to fix
      api/schemas/chefRequestSchema.ts on lines 26..37

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 173.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      const chefRequestSchema = z
  .object({
    lateEntry: z.boolean().optional(),
    idir: z.string().length(32),
    firstName: nameSchema,
      Severity: Major
      Found in api/schemas/chefRequestSchema.ts and 1 other location - About 6 hrs to fix
      app/src/schemas/chefRequestSchema.ts on lines 26..37

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 173.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function IndividualRequest has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
      Open

      const IndividualRequest = () => {
  // TODO: Consolidate these states into a single state
  const [reimbursementRequest, setReimbursementRequest] = useState<
    ReimbursementRequest | undefined
  >(undefined);
      Severity: Minor
      Found in app/src/pages/IndividualRequest.tsx - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File RequestsTable.tsx has 589 lines of code (exceeds 500 allowed). Consider refactoring.
      Confirmed

      import {
  Table,
  TableBody,
  TableContainer,
  TableHead,
      Severity: Major
      Found in app/src/components/custom/tables/RequestsTable.tsx - About 4 hrs to fix

        Function getFile has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
        Open

        export const getFile = async (req: Request, res: Response) => {
  const { id } = req.params;
  const { date } = req.query;
  const { TESTING } = Constants;
        Severity: Minor
        Found in api/controllers/requests-api-controller.ts - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

              if (!TESTING) {
        // If neither the IDIR matches nor the user is admin, return the 403
        const userInfo = getUserInfo(req.headers.authorization.split(' ')[1]); // Excludes the 'Bearer' part of token.
        const idirMatches = userInfo.idir_user_guid === record.idir;
        const isAdmin = userInfo.client_roles?.includes('admin');
        Severity: Major
        Found in api/controllers/requests-api-controller.ts and 1 other location - About 3 hrs to fix
        api/controllers/requests-api-controller.ts on lines 184..191

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 110.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function RequestForm has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
        Open

        const RequestForm = (props: RequestFormProps) => {
  const {
    locked,
    isAdmin,
    handleUpdate,
        Severity: Minor
        Found in app/src/components/custom/forms/RequestForm.tsx - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

              if (!TESTING) {
        // If neither the IDIR matches nor the user is admin, return the 403
        const userInfo = getUserInfo(req.headers.authorization.split(' ')[1]); // Excludes the 'Bearer' part of token.
        const idirMatches = userInfo.idir_user_guid === record.idir;
        const isAdmin = userInfo.client_roles?.includes('admin');
        Severity: Major
        Found in api/controllers/requests-api-controller.ts and 1 other location - About 3 hrs to fix
        api/controllers/requests-api-controller.ts on lines 383..390

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 110.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function IndividualRequest has 179 lines of code (exceeds 150 allowed). Consider refactoring.
        Open

        const IndividualRequest = () => {
  // TODO: Consolidate these states into a single state
  const [reimbursementRequest, setReimbursementRequest] = useState<
    ReimbursementRequest | undefined
  >(undefined);
        Severity: Major
        Found in app/src/pages/IndividualRequest.tsx - About 2 hrs to fix

          Function UserControl has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
          Open

          const UserControl = () => {
  const [open, setOpen] = React.useState(false);
  const anchorRef = React.useRef<HTMLButtonElement>(null);
  const { state: authState, getLoginURL, getLogoutURL } = useAuthService();
  const user = authState.userInfo;
          Severity: Minor
          Found in app/src/components/custom/login/UserControl.tsx - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function Home has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

          const Home = () => {
  const [requests, setRequests] = useState([]);
  const { BACKEND_URL, FRONTEND_URL } = Constants;
  const { state: authState } = useAuthService();
  const isAdmin = authState.userInfo.client_roles?.includes('admin');
          Severity: Minor
          Found in app/src/pages/Home.tsx - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function FileUpload has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Confirmed

          const FileUpload = (props: FileUploadProps) => {
  const { files, setFiles, index, disabled, source } = props;
  const uid = Math.random().toString();

  // Error notification
          Severity: Minor
          Found in app/src/components/custom/fileHandlers/FileUpload.tsx - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

            const {
    locked,
    isAdmin,
    handleUpdate,
    reimbursementRequest,
          Severity: Major
          Found in app/src/components/custom/forms/RequestForm.tsx and 1 other location - About 1 hr to fix
          app/src/pages/IndividualRequest.tsx on lines 206..220

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 66.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                {...{
        locked,
        isAdmin,
        handleUpdate,
        reimbursementRequest,
          Severity: Major
          Found in app/src/pages/IndividualRequest.tsx and 1 other location - About 1 hr to fix
          app/src/components/custom/forms/RequestForm.tsx on lines 85..99

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 66.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function UserRequests has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

          const UserRequests = () => {
  const [requests, setRequests] = useState([]);
  const { BACKEND_URL } = Constants;
  const { state: authState } = useAuthService();
  const isAdmin = authState.userInfo.client_roles?.includes('admin');
          Severity: Minor
          Found in app/src/pages/UserRequests.tsx - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

          const itemSchema = z.object({
  supplier: nameSchema,
  purchaseDate: datePickerSchema,
  cost: z.number().nonnegative().max(10000),
});
          Severity: Major
          Found in app/src/schemas/chefRequestSchema.ts and 1 other location - About 1 hr to fix
          api/schemas/chefRequestSchema.ts on lines 16..20

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 57.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Severity
          Category
          Status
          Source
          Language