bcgov/citz-imb-staff-purchasing-reimbursement

Avoid too many `return` statements within this function.
Open

          return data.sort((a, b) =>
            convertStateToStatus(a.state).localeCompare(convertStateToStatus(b.state)),
          );

Found in app/src/components/custom/tables/RequestsTable.tsx - About 30 mins to fix

Function `getAllRequests` has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

export const getAllRequests = async (req: Request, res: Response) => {
  const { minimal, before, after } = req.query;
  const latestPossibleDate = '3000-01-01';
  const earliestPossibleDate = '1970-01-01';
  // Query will filter out by date, but only if provided.

Found in api/controllers/requests-api-controller.ts - About 25 mins to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading