bcgov/common-forms-toolkit

Similar blocks of code found in 2 locations. Consider refactoring.

Open

const verifyString = (obj, param, result, errors) => {
  if (obj[param]) {
    if (isString(obj[param])) {
      result[param] = obj[param];
    } else {

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

  async update(req, res, next){
    try {
      const response = await this._dataService.update(req.body, req.currentUser);
      res.status(200).json(response);
    } catch (error) {

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

  async updateCurrentStatusCodes(req, res, next) {
    try {
      const response = await this._dataService.updateCurrentStatusCodes(req.body, req.currentUser);
      res.status(201).json(response);
    } catch (error) {

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  async readSubmissionPublic(req, res, next){
    try {
      const response = await this._dataService.readSubmission(req.params.submissionId, true);
      res.status(200).json(response);
    } catch (error) {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

const verifyString = (obj, param, result, errors) => {
  if (obj[param]) {
    if (isString(obj[param])) {
      result[param] = obj[param];
    } else {

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

  async createSettings(req, res, next){
    try {
      const response = await this._dataService.createSettings(req.body, req.currentUser);
      res.status(201).json(response);
    } catch (error) {

• Read up
  Read up

Similar blocks of code found in 5 locations. Consider refactoring.

Open

  async update(req, res, next){
    try {
      const response = await this._dataService.update(req.body, req.currentUser);
      res.status(200).json(response);
    } catch (error) {

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

  async readSubmissionStatusNotes (req, res, next){
    try {
      const response = await this._dataService.readSubmissionStatusNotes(req.params.statusId);
      res.status(200).json(response);
    } catch (error) {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      const currentSubmission = await this._models.Submission.query()
        .first()
        .where({submissionId: submissionId})
        .where({submissionId: obj.submissionId})
        .withGraphFetched('[business, contacts, location]')

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

  async readUserRoles(req, res, next) {
    try {
      const result = await this._service.getUserRoles(req.params.userId);
      res.status(200).json(result);
    } catch (error) {

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

  async readSubmissionStatuses(req, res, next){
    try {
      const response = await this._dataService.readSubmissionStatuses(req.params.submissionId);
      res.status(200).json(response);
    } catch (error) {

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

  async readRoleUsers(req, res, next) {
    try {
      const result = await this._service.getRoleUsers(req.params.roleId);
      res.status(200).json(result);
    } catch (error) {

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

  async readSubmissionNotes(req, res, next) {
    try {
      const response = await this._dataService.readSubmissionNotes(req.params.submissionId);
      res.status(200).json(response);
    } catch (error) {

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

  async readSettings(req, res, next) {
    try {
      const response = await this._dataService.readSettings(req.params.name);
      res.status(200).json(response);
    } catch (error) {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      const currentSubmission = await this._models.Submission.query()
        .first()
        .where({submissionId: submissionId})
        .where({submissionId: obj.submissionId})
        .withGraphFetched('[survey]')

• Read up
  Read up

Function up has 56 lines of code (exceeds 25 allowed). Consider refactoring.

Open

exports.up = function(knex) {
  return Promise.resolve()
    .then(() => knex.schema.createTable(`${PREFIX}_form`, table => {
      table.uuid('formId').references('formId').inTable('form').notNullable().primary();
      table.string('description');

File minesOperatorScreeningForm.js has 259 lines of code (exceeds 250 allowed). Consider refactoring.

Open

import moment from 'moment';

import commonFormService from '@/services/commonFormService';
import { FormNames } from '@/utils/constants';
import { SampleData, RandomCities } from './sampleData.js';

Function install has 55 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  install: function (Vue, params = {}) {
    if (installed) return;
    installed = true;

    const defaultParams = {

File agriSeafoodOpScreeningForm.js has 258 lines of code (exceeds 250 allowed). Consider refactoring.

Open

import moment from 'moment';

import commonFormService from '@/services/commonFormService';
import { FormNames } from '@/utils/constants';
import { SampleData, RandomCities } from './sampleData.js';

Similar blocks of code found in 2 locations. Consider refactoring.

Open

exports.up = function (knex) {
  return Promise.resolve()
    .then(() => knex.schema.alterTable(`${AGRI_PREFIX}_submission_location`, table => {
      table.dropColumn('licencees');
    }));

• Read up
  Read up