bcit-ci/CodeIgniter

View on GitHub
system/core/Output.php

Summary

Maintainability
D
3 days
Test Coverage

File Output.php has 390 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * CodeIgniter
 *
 * An open source application development framework for PHP
Severity: Minor
Found in system/core/Output.php - About 5 hrs to fix

    Function _display has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
    Open

        public function _display($output = NULL)
        {
            // Note:  We use load_class() because we can't use $CI =& get_instance()
            // since this function is sometimes called by the caching mechanism,
            // which happens before the CI super object is available.
    Severity: Minor
    Found in system/core/Output.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method _display has 75 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function _display($output = NULL)
        {
            // Note:  We use load_class() because we can't use $CI =& get_instance()
            // since this function is sometimes called by the caching mechanism,
            // which happens before the CI super object is available.
    Severity: Major
    Found in system/core/Output.php - About 3 hrs to fix

      Method _write_cache has 66 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function _write_cache($output)
          {
              $CI =& get_instance();
              $path = $CI->config->item('cache_path');
              $cache_path = ($path === '') ? APPPATH.'cache'.DIRECTORY_SEPARATOR : rtrim($path, '/\\').DIRECTORY_SEPARATOR;
      Severity: Major
      Found in system/core/Output.php - About 2 hrs to fix

        Function _write_cache has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

            public function _write_cache($output)
            {
                $CI =& get_instance();
                $path = $CI->config->item('cache_path');
                $cache_path = ($path === '') ? APPPATH.'cache'.DIRECTORY_SEPARATOR : rtrim($path, '/\\').DIRECTORY_SEPARATOR;
        Severity: Minor
        Found in system/core/Output.php - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method _display_cache has 43 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function _display_cache(&$CFG, &$URI)
            {
                $cache_path = ($CFG->item('cache_path') === '') ? APPPATH.'cache/' : $CFG->item('cache_path');
        
                // Build the file path. The file name is an MD5 hash of the full URI
        Severity: Minor
        Found in system/core/Output.php - About 1 hr to fix

          Method delete_cache has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function delete_cache($uri = '')
              {
                  $CI =& get_instance();
                  $cache_path = $CI->config->item('cache_path');
                  if ($cache_path === '')
          Severity: Minor
          Found in system/core/Output.php - About 1 hr to fix

            Function delete_cache has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

                public function delete_cache($uri = '')
                {
                    $CI =& get_instance();
                    $cache_path = $CI->config->item('cache_path');
                    if ($cache_path === '')
            Severity: Minor
            Found in system/core/Output.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function _display_cache has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                public function _display_cache(&$CFG, &$URI)
                {
                    $cache_path = ($CFG->item('cache_path') === '') ? APPPATH.'cache/' : $CFG->item('cache_path');
            
                    // Build the file path. The file name is an MD5 hash of the full URI
            Severity: Minor
            Found in system/core/Output.php - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function set_content_type has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                public function set_content_type($mime_type, $charset = NULL)
                {
                    if (strpos($mime_type, '/') === FALSE)
                    {
                        $extension = ltrim($mime_type, '.');
            Severity: Minor
            Found in system/core/Output.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                    if (($cache_query_string = $CI->config->item('cache_query_string')) && ! empty($_SERVER['QUERY_STRING']))
                    {
                        if (is_array($cache_query_string))
                        {
                            $uri .= '?'.http_build_query(array_intersect_key($_GET, array_flip($cache_query_string)));
            Severity: Major
            Found in system/core/Output.php and 1 other location - About 1 hr to fix
            system/core/Output.php on lines 751..761

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 90.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                        if (($cache_query_string = $CI->config->item('cache_query_string')) && ! empty($_SERVER['QUERY_STRING']))
                        {
                            if (is_array($cache_query_string))
                            {
                                $uri .= '?'.http_build_query(array_intersect_key($_GET, array_flip($cache_query_string)));
            Severity: Major
            Found in system/core/Output.php and 1 other location - About 1 hr to fix
            system/core/Output.php on lines 569..579

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 90.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status