bcit-ci/CodeIgniter

View on GitHub

Showing 877 issues of 877 total

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php
/**
 * CodeIgniter
 *
 * An open source application development framework for PHP
Severity: Major
Found in system/database/drivers/mysqli/mysqli_forge.php and 1 other location - About 6 days to fix
system/database/drivers/mysql/mysql_forge.php on lines 1..243

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 987.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php
/**
 * CodeIgniter
 *
 * An open source application development framework for PHP
Severity: Major
Found in system/database/drivers/mysql/mysql_forge.php and 1 other location - About 6 days to fix
system/database/drivers/mysqli/mysqli_forge.php on lines 1..244

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 987.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File DB_query_builder.php has 1344 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * CodeIgniter
 *
 * An open source application development framework for PHP
Severity: Major
Found in system/database/DB_query_builder.php - About 3 days to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        protected function _alter_table($alter_type, $table, $field)
         {
            if (in_array($alter_type, array('DROP', 'ADD'), TRUE))
            {
                return parent::_alter_table($alter_type, $table, $field);
    Severity: Major
    Found in system/database/drivers/pdo/subdrivers/pdo_pgsql_forge.php and 1 other location - About 3 days to fix
    system/database/drivers/postgre/postgre_forge.php on lines 103..152

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 511.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        protected function _alter_table($alter_type, $table, $field)
         {
            if (in_array($alter_type, array('DROP', 'ADD'), TRUE))
            {
                return parent::_alter_table($alter_type, $table, $field);
    Severity: Major
    Found in system/database/drivers/postgre/postgre_forge.php and 1 other location - About 3 days to fix
    system/database/drivers/pdo/subdrivers/pdo_pgsql_forge.php on lines 108..157

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 511.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    File Email.php has 1224 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    /**
     * CodeIgniter
     *
     * An open source application development framework for PHP
    Severity: Major
    Found in system/libraries/Email.php - About 3 days to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          protected function _limit($sql)
          {
              // As of SQL Server 2012 (11.0.*) OFFSET is supported
              if (version_compare($this->version(), '11', '>='))
              {
      Severity: Major
      Found in system/database/drivers/pdo/subdrivers/pdo_sqlsrv_driver.php and 1 other location - About 2 days to fix
      system/database/drivers/sqlsrv/sqlsrv_driver.php on lines 459..506

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 447.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          protected function _limit($sql)
          {
              // As of SQL Server 2012 (11.0.*) OFFSET is supported
              if (version_compare($this->version(), '11', '>='))
              {
      Severity: Major
      Found in system/database/drivers/sqlsrv/sqlsrv_driver.php and 1 other location - About 2 days to fix
      system/database/drivers/pdo/subdrivers/pdo_sqlsrv_driver.php on lines 297..344

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 447.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          protected function _alter_table($alter_type, $table, $field)
           {
              if (in_array($alter_type, array('DROP', 'ADD'), TRUE))
              {
                  return parent::_alter_table($alter_type, $table, $field);
      Severity: Major
      Found in system/database/drivers/pdo/subdrivers/pdo_firebird_forge.php and 1 other location - About 2 days to fix
      system/database/drivers/ibase/ibase_forge.php on lines 142..186

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 429.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          protected function _alter_table($alter_type, $table, $field)
           {
              if (in_array($alter_type, array('DROP', 'ADD'), TRUE))
              {
                  return parent::_alter_table($alter_type, $table, $field);
      Severity: Major
      Found in system/database/drivers/ibase/ibase_forge.php and 1 other location - About 2 days to fix
      system/database/drivers/pdo/subdrivers/pdo_firebird_forge.php on lines 128..172

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 429.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          protected function _limit($sql)
          {
              $limit = $this->qb_offset + $this->qb_limit;
      
              // As of SQL Server 2005 (9.0.*) ROW_NUMBER() is supported,
      Severity: Major
      Found in system/database/drivers/pdo/subdrivers/pdo_dblib_driver.php and 1 other location - About 2 days to fix
      system/database/drivers/mssql/mssql_driver.php on lines 430..469

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 404.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          protected function _limit($sql)
          {
              $limit = $this->qb_offset + $this->qb_limit;
      
              // As of SQL Server 2005 (9.0.*) ROW_NUMBER() is supported,
      Severity: Major
      Found in system/database/drivers/mssql/mssql_driver.php and 1 other location - About 2 days to fix
      system/database/drivers/pdo/subdrivers/pdo_dblib_driver.php on lines 273..312

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 404.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      File Xmlrpc.php has 959 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php
      /**
       * CodeIgniter
       *
       * An open source application development framework for PHP
      Severity: Major
      Found in system/libraries/Xmlrpc.php - About 2 days to fix

        File Image_lib.php has 932 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php
        /**
         * CodeIgniter
         *
         * An open source application development framework for PHP
        Severity: Major
        Found in system/libraries/Image_lib.php - About 2 days to fix

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

          <?php
          /**
           * CodeIgniter
           *
           * An open source application development framework for PHP
          Severity: Major
          Found in system/database/drivers/sqlsrv/sqlsrv_forge.php and 3 other locations - About 2 days to fix
          system/database/drivers/mssql/mssql_forge.php on lines 1..151
          system/database/drivers/pdo/subdrivers/pdo_dblib_forge.php on lines 1..149
          system/database/drivers/pdo/subdrivers/pdo_sqlsrv_forge.php on lines 1..149

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 360.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

          <?php
          /**
           * CodeIgniter
           *
           * An open source application development framework for PHP
          Severity: Major
          Found in system/database/drivers/pdo/subdrivers/pdo_dblib_forge.php and 3 other locations - About 2 days to fix
          system/database/drivers/mssql/mssql_forge.php on lines 1..151
          system/database/drivers/pdo/subdrivers/pdo_sqlsrv_forge.php on lines 1..149
          system/database/drivers/sqlsrv/sqlsrv_forge.php on lines 1..149

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 360.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

          <?php
          /**
           * CodeIgniter
           *
           * An open source application development framework for PHP
          Severity: Major
          Found in system/database/drivers/pdo/subdrivers/pdo_sqlsrv_forge.php and 3 other locations - About 2 days to fix
          system/database/drivers/mssql/mssql_forge.php on lines 1..151
          system/database/drivers/pdo/subdrivers/pdo_dblib_forge.php on lines 1..149
          system/database/drivers/sqlsrv/sqlsrv_forge.php on lines 1..149

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 360.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

          <?php
          /**
           * CodeIgniter
           *
           * An open source application development framework for PHP
          Severity: Major
          Found in system/database/drivers/mssql/mssql_forge.php and 3 other locations - About 2 days to fix
          system/database/drivers/pdo/subdrivers/pdo_dblib_forge.php on lines 1..149
          system/database/drivers/pdo/subdrivers/pdo_sqlsrv_forge.php on lines 1..149
          system/database/drivers/sqlsrv/sqlsrv_forge.php on lines 1..149

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 360.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function create_captcha has a Cognitive Complexity of 106 (exceeds 5 allowed). Consider refactoring.
          Open

              function create_captcha($data = '', $img_path = '', $img_url = '', $font_path = '')
              {
                  $defaults = array(
                      'word'        => '',
                      'img_path'    => '',
          Severity: Minor
          Found in system/helpers/captcha_helper.php - About 2 days to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          File DB_driver.php has 841 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php
          /**
           * CodeIgniter
           *
           * An open source application development framework for PHP
          Severity: Major
          Found in system/database/DB_driver.php - About 2 days to fix
            Severity
            Category
            Status