bcit-ci/CodeIgniter

View on GitHub
system/core/compat/hash.php

Summary

Maintainability
D
2 days
Test Coverage

Function hash_pbkdf2 has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
Open

    function hash_pbkdf2($algo, $password, $salt, $iterations, $length = 0, $raw_output = FALSE)
    {
        if ( ! in_array(strtolower($algo), hash_algos(), TRUE))
        {
            trigger_error('hash_pbkdf2(): Unknown hashing algorithm: '.$algo, E_USER_WARNING);
Severity: Minor
Found in system/core/compat/hash.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method hash_pbkdf2 has 112 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function hash_pbkdf2($algo, $password, $salt, $iterations, $length = 0, $raw_output = FALSE)
    {
        if ( ! in_array(strtolower($algo), hash_algos(), TRUE))
        {
            trigger_error('hash_pbkdf2(): Unknown hashing algorithm: '.$algo, E_USER_WARNING);
Severity: Major
Found in system/core/compat/hash.php - About 4 hrs to fix

    Method hash_pbkdf2 has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        function hash_pbkdf2($algo, $password, $salt, $iterations, $length = 0, $raw_output = FALSE)
    Severity: Minor
    Found in system/core/compat/hash.php - About 45 mins to fix

      Avoid too many return statements within this method.
      Open

                  return FALSE;
      Severity: Major
      Found in system/core/compat/hash.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return defined('MB_OVERLOAD_STRING')
                    ? mb_substr($hash, 0, $length, '8bit')
                    : substr($hash, 0, $length);
        Severity: Major
        Found in system/core/compat/hash.php - About 30 mins to fix

          Function hash_equals has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              function hash_equals($known_string, $user_string)
              {
                  if ( ! is_string($known_string))
                  {
                      trigger_error('hash_equals(): Expected known_string to be a string, '.strtolower(gettype($known_string)).' given', E_USER_WARNING);
          Severity: Minor
          Found in system/core/compat/hash.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (($type = gettype($iterations)) !== 'integer')
                  {
                      if ($type === 'object' && method_exists($iterations, '__toString'))
                      {
                          $iterations = (string) $iterations;
          Severity: Major
          Found in system/core/compat/hash.php and 1 other location - About 2 hrs to fix
          system/core/compat/hash.php on lines 152..168

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 111.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (($type = gettype($length)) !== 'integer')
                  {
                      if ($type === 'object' && method_exists($length, '__toString'))
                      {
                          $length = (string) $length;
          Severity: Major
          Found in system/core/compat/hash.php and 1 other location - About 2 hrs to fix
          system/core/compat/hash.php on lines 128..144

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 111.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status