bcit-ci/CodeIgniter

View on GitHub
system/database/drivers/pdo/subdrivers/pdo_firebird_forge.php

Summary

Maintainability
F
3 days
Test Coverage

Method _alter_table has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function _alter_table($alter_type, $table, $field)
     {
        if (in_array($alter_type, array('DROP', 'ADD'), TRUE))
        {
            return parent::_alter_table($alter_type, $table, $field);
Severity: Minor
Found in system/database/drivers/pdo/subdrivers/pdo_firebird_forge.php - About 1 hr to fix

    Function _alter_table has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function _alter_table($alter_type, $table, $field)
         {
            if (in_array($alter_type, array('DROP', 'ADD'), TRUE))
            {
                return parent::_alter_table($alter_type, $table, $field);
    Severity: Minor
    Found in system/database/drivers/pdo/subdrivers/pdo_firebird_forge.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

                default: return;
    Severity: Major
    Found in system/database/drivers/pdo/subdrivers/pdo_firebird_forge.php - About 30 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          protected function _alter_table($alter_type, $table, $field)
           {
              if (in_array($alter_type, array('DROP', 'ADD'), TRUE))
              {
                  return parent::_alter_table($alter_type, $table, $field);
      Severity: Major
      Found in system/database/drivers/pdo/subdrivers/pdo_firebird_forge.php and 1 other location - About 2 days to fix
      system/database/drivers/ibase/ibase_forge.php on lines 142..186

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 429.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          public function drop_database($db_name)
          {
              if ( ! ibase_drop_db($this->conn_id))
              {
                  return ($this->db->db_debug) ? $this->db->display_error('db_unable_to_drop') : FALSE;
      system/database/drivers/ibase/ibase_forge.php on lines 114..130

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 143.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          protected function _attr_type(&$attributes)
          {
              switch (strtoupper($attributes['TYPE']))
              {
                  case 'TINYINT':
      system/database/drivers/ibase/ibase_forge.php on lines 215..235
      system/database/drivers/pdo/subdrivers/pdo_4d_forge.php on lines 151..171

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 102.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status