bcit-ci/CodeIgniter

View on GitHub
system/libraries/Encryption.php

Summary

Maintainability
F
4 days
Test Coverage

File Encryption.php has 529 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * CodeIgniter
 *
 * An open source application development framework for PHP
Severity: Major
Found in system/libraries/Encryption.php - About 1 day to fix

    Method _get_params has 64 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function _get_params($params)
        {
            if (empty($params))
            {
                return isset($this->_cipher, $this->_mode, $this->_key, $this->_handle)
    Severity: Major
    Found in system/libraries/Encryption.php - About 2 hrs to fix

      Function _mcrypt_initialize has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function _mcrypt_initialize($params)
          {
              if ( ! empty($params['cipher']))
              {
                  $params['cipher'] = strtolower($params['cipher']);
      Severity: Minor
      Found in system/libraries/Encryption.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _get_params has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function _get_params($params)
          {
              if (empty($params))
              {
                  return isset($this->_cipher, $this->_mode, $this->_key, $this->_handle)
      Severity: Minor
      Found in system/libraries/Encryption.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method _mcrypt_initialize has 43 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function _mcrypt_initialize($params)
          {
              if ( ! empty($params['cipher']))
              {
                  $params['cipher'] = strtolower($params['cipher']);
      Severity: Minor
      Found in system/libraries/Encryption.php - About 1 hr to fix

        Method _mcrypt_decrypt has 39 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function _mcrypt_decrypt($data, $params)
            {
                if ( ! is_resource($params['handle']))
                {
                    return FALSE;
        Severity: Minor
        Found in system/libraries/Encryption.php - About 1 hr to fix

          Method _openssl_initialize has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              protected function _openssl_initialize($params)
              {
                  if ( ! empty($params['cipher']))
                  {
                      $params['cipher'] = strtolower($params['cipher']);
          Severity: Minor
          Found in system/libraries/Encryption.php - About 1 hr to fix

            Method decrypt has 33 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function decrypt($data, array $params = NULL)
                {
                    if (($params = $this->_get_params($params)) === FALSE)
                    {
                        return FALSE;
            Severity: Minor
            Found in system/libraries/Encryption.php - About 1 hr to fix

              Function _mcrypt_decrypt has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function _mcrypt_decrypt($data, $params)
                  {
                      if ( ! is_resource($params['handle']))
                      {
                          return FALSE;
              Severity: Minor
              Found in system/libraries/Encryption.php - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method _mcrypt_encrypt has 30 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  protected function _mcrypt_encrypt($data, $params)
                  {
                      if ( ! is_resource($params['handle']))
                      {
                          return FALSE;
              Severity: Minor
              Found in system/libraries/Encryption.php - About 1 hr to fix

                Method initialize has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function initialize(array $params)
                    {
                        if ( ! empty($params['driver']))
                        {
                            if (isset($this->_drivers[$params['driver']]))
                Severity: Minor
                Found in system/libraries/Encryption.php - About 1 hr to fix

                  Method _cipher_alias has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      protected function _cipher_alias(&$cipher)
                      {
                          static $dictionary;
                  
                          if (empty($dictionary))
                  Severity: Minor
                  Found in system/libraries/Encryption.php - About 1 hr to fix

                    Function initialize has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function initialize(array $params)
                        {
                            if ( ! empty($params['driver']))
                            {
                                if (isset($this->_drivers[$params['driver']]))
                    Severity: Minor
                    Found in system/libraries/Encryption.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function decrypt has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function decrypt($data, array $params = NULL)
                        {
                            if (($params = $this->_get_params($params)) === FALSE)
                            {
                                return FALSE;
                    Severity: Minor
                    Found in system/libraries/Encryption.php - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Function _openssl_initialize has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                    Open

                        protected function _openssl_initialize($params)
                        {
                            if ( ! empty($params['cipher']))
                            {
                                $params['cipher'] = strtolower($params['cipher']);
                    Severity: Minor
                    Found in system/libraries/Encryption.php - About 55 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method hkdf has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        public function hkdf($key, $digest = 'sha512', $salt = NULL, $length = NULL, $info = '')
                    Severity: Minor
                    Found in system/libraries/Encryption.php - About 35 mins to fix

                      Avoid too many return statements within this method.
                      Open

                              return $params;
                      Severity: Major
                      Found in system/libraries/Encryption.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                            return FALSE;
                        Severity: Major
                        Found in system/libraries/Encryption.php - About 30 mins to fix

                          Function _mcrypt_encrypt has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                              protected function _mcrypt_encrypt($data, $params)
                              {
                                  if ( ! is_resource($params['handle']))
                                  {
                                      return FALSE;
                          Severity: Minor
                          Found in system/libraries/Encryption.php - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                  if ( ! empty($params['mode']))
                                  {
                                      $params['mode'] = strtolower($params['mode']);
                                      if ( ! isset($this->_modes['openssl'][$params['mode']]))
                                      {
                          Severity: Major
                          Found in system/libraries/Encryption.php and 1 other location - About 2 hrs to fix
                          system/libraries/Encryption.php on lines 244..255

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 110.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                  if ( ! empty($params['mode']))
                                  {
                                      $params['mode'] = strtolower($params['mode']);
                                      if ( ! isset($this->_modes['mcrypt'][$params['mode']]))
                                      {
                          Severity: Major
                          Found in system/libraries/Encryption.php and 1 other location - About 2 hrs to fix
                          system/libraries/Encryption.php on lines 295..306

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 110.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          There are no issues that match your filters.

                          Category
                          Status