bemusic/bemuse

View on GitHub
bemuse/src/custom-song-loader/index.ts

Summary

Maintainability
C
7 hrs
Test Coverage

Function loadSongFromResources has 78 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function loadSongFromResources(
  resources: ICustomSongResources,
  options: LoadSongOptions = {}
) {
  const onMessage = options.onMessage || (() => {})
Severity: Major
Found in bemuse/src/custom-song-loader/index.ts - About 3 hrs to fix

    Function loadFromBmsFileList has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      async function loadFromBmsFileList(bmsFileList: string[]) {
        onMessage(bmsFileList.length + ' file(s) found. Reading them...')
        const files = await Promise.all(
          bmsFileList.map(async (filename) => {
            const start = Date.now()
    Severity: Minor
    Found in bemuse/src/custom-song-loader/index.ts - About 1 hr to fix

      Function loadSongFromResources has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

      export function loadSongFromResources(
        resources: ICustomSongResources,
        options: LoadSongOptions = {}
      ) {
        const onMessage = options.onMessage || (() => {})
      Severity: Minor
      Found in bemuse/src/custom-song-loader/index.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function song has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          const song = await new Promise<Song>((resolve, reject) => {
            const worker = new Worker(
              // @ts-ignore
              new URL('./song-loader.worker.js', import.meta.url)
            )
      Severity: Minor
      Found in bemuse/src/custom-song-loader/index.ts - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status