bemusic/bemuse

View on GitHub

Showing 494 of 494 total issues

Function update has a Cognitive Complexity of 97 (exceeds 5 allowed). Consider refactoring.
Open

  update(time, gameTime, playerState) {
    const touch3dMode = this._touch3dMode
    let player = this._player
    let noteArea = this._noteArea
    let stateful = this._stateful
Severity: Minor
Found in bemuse/src/game/display/player-display.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function tests has 349 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function tests(onlineServiceOptions) {
  function createOnline() {
    return new Online(new OnlineService(onlineServiceOptions))
  }

Severity: Major
Found in bemuse/src/online/index.spec.js - About 1 day to fix

    Function TouchPlugin has a Cognitive Complexity of 69 (exceeds 5 allowed). Consider refactoring.
    Open

    export function TouchPlugin(context) {
      let scratchStartY = null
      let scratchY = null
      let getInput = bench.wrap('input:touch:I', _getInput)
      let getScratch = bench.wrap('input:touch:SC', _getScratch)
    Severity: Minor
    Found in bemuse/src/game/input/touch-plugin.js - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Identical blocks of code found in 7 locations. Consider refactoring.
    Open

    const chartPropType = PropTypes.shape({
      bpm: PropTypes.shape({
        init: PropTypes.number,
        max: PropTypes.number,
        median: PropTypes.number,
    Severity: Major
    Found in bemuse/src/app/ui/MusicListItemChart.jsx and 6 other locations - About 1 day to fix
    bemuse/src/app/ui/MusicInfo.jsx on lines 9..30
    bemuse/src/app/ui/MusicInfoTabs.jsx on lines 12..33
    bemuse/src/app/ui/MusicList.jsx on lines 8..29
    bemuse/src/app/ui/MusicListItem.jsx on lines 10..31
    bemuse/src/app/ui/MusicListItemCharts.jsx on lines 7..28
    bemuse/src/app/ui/withPersonalRecord.jsx on lines 16..37

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 204.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 7 locations. Consider refactoring.
    Open

    const chartPropType = PropTypes.shape({
      bpm: PropTypes.shape({
        init: PropTypes.number,
        max: PropTypes.number,
        median: PropTypes.number,
    Severity: Major
    Found in bemuse/src/app/ui/MusicList.jsx and 6 other locations - About 1 day to fix
    bemuse/src/app/ui/MusicInfo.jsx on lines 9..30
    bemuse/src/app/ui/MusicInfoTabs.jsx on lines 12..33
    bemuse/src/app/ui/MusicListItem.jsx on lines 10..31
    bemuse/src/app/ui/MusicListItemChart.jsx on lines 6..27
    bemuse/src/app/ui/MusicListItemCharts.jsx on lines 7..28
    bemuse/src/app/ui/withPersonalRecord.jsx on lines 16..37

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 204.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 7 locations. Consider refactoring.
    Open

    const chartPropType = PropTypes.shape({
      bpm: PropTypes.shape({
        init: PropTypes.number,
        max: PropTypes.number,
        median: PropTypes.number,
    Severity: Major
    Found in bemuse/src/app/ui/withPersonalRecord.jsx and 6 other locations - About 1 day to fix
    bemuse/src/app/ui/MusicInfo.jsx on lines 9..30
    bemuse/src/app/ui/MusicInfoTabs.jsx on lines 12..33
    bemuse/src/app/ui/MusicList.jsx on lines 8..29
    bemuse/src/app/ui/MusicListItem.jsx on lines 10..31
    bemuse/src/app/ui/MusicListItemChart.jsx on lines 6..27
    bemuse/src/app/ui/MusicListItemCharts.jsx on lines 7..28

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 204.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 7 locations. Consider refactoring.
    Open

    const chartPropType = PropTypes.shape({
      bpm: PropTypes.shape({
        init: PropTypes.number,
        max: PropTypes.number,
        median: PropTypes.number,
    Severity: Major
    Found in bemuse/src/app/ui/MusicInfoTabs.jsx and 6 other locations - About 1 day to fix
    bemuse/src/app/ui/MusicInfo.jsx on lines 9..30
    bemuse/src/app/ui/MusicList.jsx on lines 8..29
    bemuse/src/app/ui/MusicListItem.jsx on lines 10..31
    bemuse/src/app/ui/MusicListItemChart.jsx on lines 6..27
    bemuse/src/app/ui/MusicListItemCharts.jsx on lines 7..28
    bemuse/src/app/ui/withPersonalRecord.jsx on lines 16..37

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 204.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 7 locations. Consider refactoring.
    Open

    const chartPropType = PropTypes.shape({
      bpm: PropTypes.shape({
        init: PropTypes.number,
        max: PropTypes.number,
        median: PropTypes.number,
    Severity: Major
    Found in bemuse/src/app/ui/MusicInfo.jsx and 6 other locations - About 1 day to fix
    bemuse/src/app/ui/MusicInfoTabs.jsx on lines 12..33
    bemuse/src/app/ui/MusicList.jsx on lines 8..29
    bemuse/src/app/ui/MusicListItem.jsx on lines 10..31
    bemuse/src/app/ui/MusicListItemChart.jsx on lines 6..27
    bemuse/src/app/ui/MusicListItemCharts.jsx on lines 7..28
    bemuse/src/app/ui/withPersonalRecord.jsx on lines 16..37

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 204.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 7 locations. Consider refactoring.
    Open

    const chartPropType = PropTypes.shape({
      bpm: PropTypes.shape({
        init: PropTypes.number,
        max: PropTypes.number,
        median: PropTypes.number,
    Severity: Major
    Found in bemuse/src/app/ui/MusicListItem.jsx and 6 other locations - About 1 day to fix
    bemuse/src/app/ui/MusicInfo.jsx on lines 9..30
    bemuse/src/app/ui/MusicInfoTabs.jsx on lines 12..33
    bemuse/src/app/ui/MusicList.jsx on lines 8..29
    bemuse/src/app/ui/MusicListItemChart.jsx on lines 6..27
    bemuse/src/app/ui/MusicListItemCharts.jsx on lines 7..28
    bemuse/src/app/ui/withPersonalRecord.jsx on lines 16..37

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 204.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 7 locations. Consider refactoring.
    Open

    const chartPropType = PropTypes.shape({
      bpm: PropTypes.shape({
        init: PropTypes.number,
        max: PropTypes.number,
        median: PropTypes.number,
    Severity: Major
    Found in bemuse/src/app/ui/MusicListItemCharts.jsx and 6 other locations - About 1 day to fix
    bemuse/src/app/ui/MusicInfo.jsx on lines 9..30
    bemuse/src/app/ui/MusicInfoTabs.jsx on lines 12..33
    bemuse/src/app/ui/MusicList.jsx on lines 8..29
    bemuse/src/app/ui/MusicListItem.jsx on lines 10..31
    bemuse/src/app/ui/MusicListItemChart.jsx on lines 6..27
    bemuse/src/app/ui/withPersonalRecord.jsx on lines 16..37

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 204.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function createMusicPreviewer has a Cognitive Complexity of 53 (exceeds 5 allowed). Consider refactoring.
    Open

    function createMusicPreviewer() {
      let enabled = false
      let currentUrl = null
      let backgroundLoaded = false
      let backgroundPlayed = false
    Severity: Minor
    Found in bemuse/src/music-previewer/index.js - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function Online has 189 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function Online(service) {
      const user口 = new Bacon.Bus()
      const seen口 = new Bacon.Bus()
      const submitted口 = new Bacon.Bus()
    
    
    Severity: Major
    Found in bemuse/src/online/index.js - About 7 hrs to fix

      Function update has 182 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        update(time, gameTime, playerState) {
          const touch3dMode = this._touch3dMode
          let player = this._player
          let noteArea = this._noteArea
          let stateful = this._stateful
      Severity: Major
      Found in bemuse/src/game/display/player-display.js - About 7 hrs to fix

        File index.ts has 455 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        import _ from 'lodash'
        import { get, set, del } from 'idb-keyval'
        import pMemoize from 'p-memoize'
        import {
          CustomFolderChartFile,
        Severity: Minor
        Found in bemuse/src/custom-folder/index.ts - About 6 hrs to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  it('ends automatically', function () {
                    advance(2, { p1_SC: 1 })
                    assert(state.getNoteStatus(note) === 'active')
                    assert(state.getNoteJudgment(note) === 1)
                    assert(state.notifications.judgments[0].judgment === 1)
          Severity: Major
          Found in bemuse/src/game/state/player-state.spec.js and 1 other location - About 6 hrs to fix
          bemuse/src/game/state/player-state.spec.js on lines 167..176

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 171.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  it('judges long note', function () {
                    advance(2, { p1_1: 1 })
                    assert(state.getNoteStatus(note) === 'active')
                    assert(state.getNoteJudgment(note) === 1)
                    assert(state.notifications.judgments[0].judgment === 1)
          Severity: Major
          Found in bemuse/src/game/state/player-state.spec.js and 1 other location - About 6 hrs to fix
          bemuse/src/game/state/player-state.spec.js on lines 234..243

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 171.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function load has 163 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          export function load(spec: LoadSpec) {
            const assets = spec.assets
            const bms = spec.bms
            const songId = spec.songId
          
          
          Severity: Major
          Found in bemuse/src/game/loaders/game-loader.ts - About 6 hrs to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              return {
                initialBPM: bmson.info.init_bpm,
                actions: [
                  ...(bmson.bpm_events || []).map(
                    ({ y, bpm }) =>
            Severity: Major
            Found in packages/bmson/src/index.ts and 1 other location - About 6 hrs to fix
            packages/bmson/src/legacy.ts on lines 25..45

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 165.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

              return {
                initialBPM: bmson.info.initBPM,
                actions: [
                  ...(bmson.bpmNotes || []).map(
                    ({ y, v }) =>
            Severity: Major
            Found in packages/bmson/src/legacy.ts and 1 other location - About 6 hrs to fix
            packages/bmson/src/index.ts on lines 58..78

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 165.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                it('handles keysound slices', function () {
                  let score = setup([
                    { x: 1, y: 240, l: 0, c: false },
                    { x: 1, y: 480, l: 0, c: true },
                  ])
            Severity: Major
            Found in packages/bmson/src/legacy.spec.ts and 1 other location - About 6 hrs to fix
            packages/bmson/src/index.spec.ts on lines 163..173

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 163.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Severity
            Category
            Status
            Source
            Language