bemusic/bemuse

View on GitHub
bemuse/src/online/index.ts

Summary

Maintainability
C
1 day
Test Coverage

File index.ts has 313 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import {
  Action,
  DataStore,
  initialState,
  put,
Severity: Minor
Found in bemuse/src/online/index.ts - About 3 hrs to fix

    Online has 26 functions (exceeds 20 allowed). Consider refactoring.
    Open

    export class Online {
      constructor(private readonly service: InternetRankingService) {}
    
      /** @deprecated */
      private user口 = new Subject<UserInfo | null>()
    Severity: Minor
    Found in bemuse/src/online/index.ts - About 3 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        async signUp(options: SignUpInfo) {
          const user = await this.service.signUp(options)
          this.user口.next(user)
          queryClient.invalidateQueries({ queryKey: rootQueryKey })
          return user
      Severity: Major
      Found in bemuse/src/online/index.ts and 1 other location - About 1 hr to fix
      bemuse/src/online/index.ts on lines 163..168

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 71.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        async logIn(options: LogInInfo) {
          const user = await this.service.logIn(options)
          this.user口.next(user)
          queryClient.invalidateQueries({ queryKey: rootQueryKey })
          return user
      Severity: Major
      Found in bemuse/src/online/index.ts and 1 other location - About 1 hr to fix
      bemuse/src/online/index.ts on lines 156..161

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 71.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      export interface ScoreBase {
        score: number
        combo: number
        count: ScoreCount
        total: number
      Severity: Minor
      Found in bemuse/src/online/index.ts and 1 other location - About 35 mins to fix
      bemuse/src/online/scoreboard-system/createFakeScoreboardClient.ts on lines 189..195

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        private submissionModel = (
          retrySelfBus: Observable<void>,
          data: ScoreInfo
        ): Observable<SubmissionOperation> =>
          merge(this.asap川([[]]), retrySelfBus).pipe(
      Severity: Minor
      Found in bemuse/src/online/index.ts and 1 other location - About 30 mins to fix
      bemuse/src/online/index.ts on lines 358..364

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        private getScoreboardState川 = (
          retryScoreboardBus: Observable<void>,
          level: RecordLevel
        ): Observable<Operation<{ data: ScoreboardDataEntry[] }>> =>
          merge(this.asap川([[]]), retryScoreboardBus).pipe(
      Severity: Minor
      Found in bemuse/src/online/index.ts and 1 other location - About 30 mins to fix
      bemuse/src/online/index.ts on lines 342..348

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status