Sign upLogin

bemusic/bemuse

View on GitHub
Star
bemuse/src/previewer/PreviewCanvas.tsx

Summary

Maintainability
C
1 day
Test Coverage

Function PreviewCanvas has 138 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const PreviewCanvas: FC<PreviewCanvas> = (props) => {
  const keymap = 'SCs 1 2b 3 4g 5 6b 7 - 8 9b 10 11g 12 13b 14 SC2s'
  const notesImage = useImage('/skins/default/Note/DX/Note.png')
  const landmineImage = useImage('/skins/default/Note/DX/Landmine.png')
  const canvasRef = React.useRef<HTMLCanvasElement>(null)
Severity: Major
Found in bemuse/src/previewer/PreviewCanvas.tsx - About 5 hrs to fix

    Function constructor has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      constructor(keymap: string) {
    let nextX = 0
    const column = (width: number, name: string | null): PreviewColumn => {
      const x = nextX
      nextX += width + 1
    Severity: Minor
    Found in bemuse/src/previewer/PreviewCanvas.tsx - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                if (noteHeight > 0) {
              ctx.drawImage(
                notesImage,
                column.sprite.x,
                22 + spriteYOffset,
    Severity: Major
    Found in bemuse/src/previewer/PreviewCanvas.tsx - About 45 mins to fix

      Avoid too many return statements within this function.
      Open

            return noteColumn(sprites.white, c)
      Severity: Major
      Found in bemuse/src/previewer/PreviewCanvas.tsx - About 30 mins to fix

        Similar blocks of code found in 5 locations. Consider refactoring.
        Open

          const comboInfo = useMemo(() => {
    return props.notechartPreview.getComboInfo(props.previewState.currentTime)
  }, [props.notechartPreview, props.previewState.currentTime])
        Severity: Major
        Found in bemuse/src/previewer/PreviewCanvas.tsx and 4 other locations - About 1 hr to fix
        bemuse/src/previewer/PreviewInfo.tsx on lines 15..17
        bemuse/src/previewer/PreviewInfo.tsx on lines 18..20
        bemuse/src/previewer/PreviewInfo.tsx on lines 21..25
        bemuse/src/previewer/PreviewInfo.tsx on lines 26..30

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 55.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    ctx.drawImage(
              notesImage,
              column.sprite.x,
              12 + spriteYOffset,
              column.width,
        Severity: Minor
        Found in bemuse/src/previewer/PreviewCanvas.tsx and 1 other location - About 50 mins to fix
        bemuse/src/previewer/PreviewCanvas.tsx on lines 125..135

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    ctx.drawImage(
              notesImage,
              column.sprite.x,
              104 + spriteYOffset,
              column.width,
        Severity: Minor
        Found in bemuse/src/previewer/PreviewCanvas.tsx and 1 other location - About 50 mins to fix
        bemuse/src/previewer/PreviewCanvas.tsx on lines 136..146

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status