Sign upLogin

bemusic/bemuse

View on GitHub
Star

Showing 508 of 508 total issues

File MusicSelectScene.tsx has 344 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import './MusicSelectScene.scss'

import * as Analytics from '../analytics'
import * as MusicPreviewer from 'bemuse/music-previewer'
import * as MusicSearchIO from '../io/MusicSearchIO'
Severity: Minor
Found in bemuse/src/app/ui/MusicSelectScene.tsx - About 4 hrs to fix

    Function index has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
    Open

    export async function index(path, { recursive }) {
  const stat = await fileStat(path)
  if (!stat.isDirectory()) throw new Error('Not a directory: ' + path)

  const cache = new Cache(join(path, 'index.cache'))
    Severity: Minor
    Found in packages/bemuse-tools/src/indexer.js - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function CustomFolderTester has 105 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const CustomFolderTester = () => {
  const context = getDefaultCustomFolderContext()
  const { isLoading, error, data } = useQuery('customFolder', async () => {
    const result = await getCustomFolderState(context)
    return result
    Severity: Major
    Found in bemuse/src/devtools/playgrounds/custom-folder.tsx - About 4 hrs to fix

      Function applyWebConfig has 103 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function applyWebConfig(config) {
  Object.assign(config, {
    entry: {
      boot: ['./boot'],
    },
      Severity: Major
      Found in bemuse/config/webpack.js - About 4 hrs to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

        var __importStar = (this && this.__importStar) || function (mod) {
    if (mod && mod.__esModule) return mod;
    var result = {};
    if (mod != null) for (var k in mod) if (k !== "default" && Object.prototype.hasOwnProperty.call(mod, k)) __createBinding(result, mod, k);
    __setModuleDefault(result, mod);
        Severity: Major
        Found in common/scripts/install-run-rush.js and 1 other location - About 4 hrs to fix
        common/scripts/install-run.js on lines 20..26

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 115.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

        var __importStar = (this && this.__importStar) || function (mod) {
    if (mod && mod.__esModule) return mod;
    var result = {};
    if (mod != null) for (var k in mod) if (k !== "default" && Object.prototype.hasOwnProperty.call(mod, k)) __createBinding(result, mod, k);
    __setModuleDefault(result, mod);
        Severity: Major
        Found in common/scripts/install-run.js and 1 other location - About 4 hrs to fix
        common/scripts/install-run-rush.js on lines 20..26

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 115.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function BemusePreviewer has 99 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export const BemusePreviewer = () => {
  const div = useRef<HTMLDivElement>(null)
  const [previewState, dispatch] = useReducer(previewStateReducer, {
    currentTime: 0,
    hiSpeed: 1,
        Severity: Major
        Found in bemuse/src/previewer/BemusePreviewer.tsx - About 3 hrs to fix

          Notechart has 31 functions (exceeds 20 allowed). Consider refactoring.
          Open

          export class Notechart {
  private _timing: BMS.Timing
  private _keysounds: BMS.Keysounds
  private _positioning: BMS.Positioning
  private _spacing: BMS.Spacing
          Severity: Minor
          Found in packages/bemuse-notechart/src/index.ts - About 3 hrs to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  auth.client.login(
        {
          realm: 'Username-Password-Authentication',
          username: playerId,
          password: password,
            Severity: Major
            Found in bemuse/src/online/scoreboard-system/createLegacyScoreboardClient.ts and 1 other location - About 3 hrs to fix
            bemuse/src/online/scoreboard-system/createLegacyScoreboardClient.ts on lines 58..73

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 111.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                      auth.client.login(
            {
              realm: 'Username-Password-Authentication',
              username: username,
              password: password,
            Severity: Major
            Found in bemuse/src/online/scoreboard-system/createLegacyScoreboardClient.ts and 1 other location - About 3 hrs to fix
            bemuse/src/online/scoreboard-system/createLegacyScoreboardClient.ts on lines 93..108

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 111.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            File game-launcher.tsx has 322 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            import * as Analytics from './analytics'
import * as Options from './entities/Options'

import { Chart, Song } from 'bemuse/collection-model/types'
import { ReactScene, SceneManager } from 'bemuse/scene-manager'
            Severity: Minor
            Found in bemuse/src/app/game-launcher.tsx - About 3 hrs to fix

              Function PreviewKeyHandler has 92 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              export const PreviewKeyHandler: FC<PreviewKeyHandler> = (props) => {
  const getLatestNotechartPreview = useLatest(props.notechartPreview)
  useEffect(() => {
    const onKeyDown = (e: KeyboardEvent) => {
      if (isModalActive()) return
              Severity: Major
              Found in bemuse/src/previewer/PreviewKeyHandler.tsx - About 3 hrs to fix

                Function go has 89 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                async function go(loader, element) {
  const master = new SamplingMaster(ctx)
  const $log = element.find('.js-log')
  const $play = element.find('.js-play').hide()
  const $sampler = element.find('.js-sampler')
                Severity: Major
                Found in bemuse/src/coming-soon/demo/index.js - About 3 hrs to fix

                  File player-state.ts has 313 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  import _ from 'lodash'

import PlayerStats from './player-stats'
import {
  MISSED,
                  Severity: Minor
                  Found in bemuse/src/game/state/player-state.ts - About 3 hrs to fix

                    File index.ts has 313 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    import {
  Action,
  DataStore,
  initialState,
  put,
                    Severity: Minor
                    Found in bemuse/src/online/index.ts - About 3 hrs to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                        it('selects the chart if available', () =>
    givenSelectedChart.then(
      MusicSelection.selectedChartGivenCharts([
        { file: 'chart0.bml', info: { level: 1 } },
        { file: 'chart1.bml', info: { level: 8 } },
                      Severity: Major
                      Found in bemuse/src/app/entities/MusicSelection.spec.js and 1 other location - About 3 hrs to fix
                      bemuse/src/app/entities/MusicSelection.spec.js on lines 44..52

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 104.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                        it('selects chart with closest level if matching chart not available', () =>
    givenSelectedChart.then(
      MusicSelection.selectedChartGivenCharts([
        { file: 'pattern0.bml', info: { level: 2 } },
        { file: 'pattern1.bml', info: { level: 9 } },
                      Severity: Major
                      Found in bemuse/src/app/entities/MusicSelection.spec.js and 1 other location - About 3 hrs to fix
                      bemuse/src/app/entities/MusicSelection.spec.js on lines 35..43

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 104.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Function music has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
                      Open

                      function music(master: SamplingMaster, samples: Samples) {
  return function play(callbacks: { a: () => void }) {
    master.unmute()

    const BPM = 148
                      Severity: Minor
                      Found in bemuse/src/auto-synchro/music/index.ts - About 3 hrs to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function compile has 85 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                      export function compile(text: string, options?: Partial<BMSCompileOptions>) {
  options = options || {}

  const chart = new BMSChart()
                      Severity: Major
                      Found in packages/bms/src/compiler/index.ts - About 3 hrs to fix

                        Function PreviewInfo has 85 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                        export const PreviewInfo: FC<PreviewInfo> = (props) => {
  const preview = props.notechartPreview

  const measureInfo = useMemo(() => {
    return props.notechartPreview.getMeasureInfo(props.previewState.currentTime)
                        Severity: Major
                        Found in bemuse/src/previewer/PreviewInfo.tsx - About 3 hrs to fix
                          Severity
                          Category
                          Status
                          Source
                          Language