Sign upLogin

berict/Tapad

View on GitHub
Star
app/src/main/java/com/bedrock/padder/activity/SettingsActivity.java

Summary

Maintainability
D
1 day
Test Coverage

SettingsActivity has 35 methods (exceeds 20 allowed). Consider refactoring.
Open

public class SettingsActivity extends AppCompatActivity {

    private WindowHelper w = new WindowHelper();
    private AnimateHelper anim = new AnimateHelper();
    private IntentHelper intent = new IntentHelper();
Severity: Minor
Found in app/src/main/java/com/bedrock/padder/activity/SettingsActivity.java - About 4 hrs to fix

    File SettingsActivity.java has 351 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    package com.bedrock.padder.activity;

import android.app.Activity;
import android.content.DialogInterface;
import android.os.Bundle;
    Severity: Minor
    Found in app/src/main/java/com/bedrock/padder/activity/SettingsActivity.java - About 4 hrs to fix

      Method setDeckMargin has 65 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private void setDeckMargin() {
        // deck margin

        deckMarginEditText = ((EditText) a.findViewById(R.id.layout_settings_deck_margin_input));
        deckMarginSeekbar = ((SeekBar) a.findViewById(R.id.layout_settings_deck_margin_slider));
      Severity: Major
      Found in app/src/main/java/com/bedrock/padder/activity/SettingsActivity.java - About 2 hrs to fix

        Method setIntents has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private void setIntents() {
        // presets
        (a.findViewById(R.id.layout_settings_preset)).setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View v) {
        Severity: Minor
        Found in app/src/main/java/com/bedrock/padder/activity/SettingsActivity.java - About 1 hr to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  (a.findViewById(R.id.layout_settings_layout)).setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View v) {
                Toast.makeText(a, R.string.settings_layout_error, Toast.LENGTH_SHORT).show();
            }
          Severity: Minor
          Found in app/src/main/java/com/bedrock/padder/activity/SettingsActivity.java and 1 other location - About 30 mins to fix
          app/src/main/java/com/bedrock/padder/activity/SettingsActivity.java on lines 115..120

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 42.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  (a.findViewById(R.id.layout_settings_preset)).setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View v) {
                if (isPresetVisible == false) {
                    intent.intent(a, "activity.PresetStoreActivity");
          Severity: Minor
          Found in app/src/main/java/com/bedrock/padder/activity/SettingsActivity.java and 1 other location - About 30 mins to fix
          app/src/main/java/com/bedrock/padder/fragment/AboutFragment.java on lines 192..199

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 42.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  (a.findViewById(R.id.layout_settings_custom_touch)).setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View v) {
                Toast.makeText(a, R.string.settings_custom_touch_error, Toast.LENGTH_SHORT).show();
            }
          Severity: Minor
          Found in app/src/main/java/com/bedrock/padder/activity/SettingsActivity.java and 1 other location - About 30 mins to fix
          app/src/main/java/com/bedrock/padder/activity/SettingsActivity.java on lines 122..127

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 42.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status