Sign upLogin

berict/Tapad

View on GitHub
Star
app/src/main/java/com/bedrock/padder/adapter/ColorAdapter.java

Summary

Maintainability
B
5 hrs
Test Coverage

Method onBindViewHolder has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @Override
    public void onBindViewHolder(final DetailViewHolder holder, int position) {
        Log.d("Holder", String.valueOf(itemColor.getColorButtonRecent(position)));
        final int color = itemColor.getColorButtonRecent(position);
Severity: Major
Found in app/src/main/java/com/bedrock/padder/adapter/ColorAdapter.java - About 2 hrs to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            try {
            ((TextView) activity.findViewById(R.id.layout_color_id)).setText(String.format("#%06X", (0xFFFFFF & activity.getResources().getColor(primaryColor))));
        } catch (Resources.NotFoundException e) {
            ((TextView) activity.findViewById(R.id.layout_color_id)).setText(String.format("#%06X", (0xFFFFFF & primaryColor)));
        }
    Severity: Major
    Found in app/src/main/java/com/bedrock/padder/adapter/ColorAdapter.java and 1 other location - About 1 hr to fix
    app/src/main/java/com/bedrock/padder/activity/ColorActivity.java on lines 133..137

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 78.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

            for (int i = 0; i < 4; i++) {
            colorView[i].setBackgroundColor(
                    getBlendColor(
                            primaryColor,
                            R.color.grey,
    Severity: Major
    Found in app/src/main/java/com/bedrock/padder/adapter/ColorAdapter.java and 2 other locations - About 45 mins to fix
    app/src/main/java/com/bedrock/padder/activity/ColorActivity.java on lines 122..131
    app/src/main/java/com/bedrock/padder/adapter/ColorAdapter.java on lines 86..95

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 56.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

            for (int i = 0; i < 4; i++) {
            colorView[i].setBackgroundColor(
                    getBlendColor(
                            color,
                            R.color.grey,
    Severity: Major
    Found in app/src/main/java/com/bedrock/padder/adapter/ColorAdapter.java and 2 other locations - About 45 mins to fix
    app/src/main/java/com/bedrock/padder/activity/ColorActivity.java on lines 122..131
    app/src/main/java/com/bedrock/padder/adapter/ColorAdapter.java on lines 164..173

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 56.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

        public ColorAdapter(ItemColor itemColor, int rowLayout, Preferences preferences, Activity activity) {
        this.itemColor = itemColor;
        this.rowLayout = rowLayout;
        this.preferences = preferences;
        this.activity = activity;
    Severity: Major
    Found in app/src/main/java/com/bedrock/padder/adapter/ColorAdapter.java and 6 other locations - About 40 mins to fix
    app/src/main/java/com/bedrock/padder/adapter/DetailAdapter.java on lines 32..37
    app/src/main/java/com/bedrock/padder/adapter/ItemAdapter.java on lines 54..59
    app/src/main/java/com/bedrock/padder/model/about/Bio.java on lines 20..25
    app/src/main/java/com/bedrock/padder/model/about/Item.java on lines 35..40
    app/src/main/java/com/bedrock/padder/model/preset/PresetSchema.java on lines 183..188
    app/src/main/java/com/bedrock/padder/model/preset/Review.java on lines 15..20

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status