Sign upLogin

berict/Tapad

View on GitHub
Star
app/src/main/java/com/bedrock/padder/fragment/PresetStoreOnlineFragment.java

Summary

Maintainability
D
1 day
Test Coverage

Method setAdapter has 121 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private void setAdapter() {
        if (isPresetDownloading) {
            // attach adapter while its not null
            presetStoreAdapter = new PresetStoreAdapter(
                    online,
Severity: Major
Found in app/src/main/java/com/bedrock/padder/fragment/PresetStoreOnlineFragment.java - About 4 hrs to fix

    File PresetStoreOnlineFragment.java has 279 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    package com.bedrock.padder.fragment;

import android.content.Context;
import android.content.DialogInterface;
import android.content.pm.PackageInfo;
    Severity: Minor
    Found in app/src/main/java/com/bedrock/padder/fragment/PresetStoreOnlineFragment.java - About 2 hrs to fix

      PresetStoreOnlineFragment has 22 methods (exceeds 20 allowed). Consider refactoring.
      Open

      public class PresetStoreOnlineFragment extends Fragment implements Refreshable {

    private WindowHelper window = new WindowHelper();
    private AnimateHelper anim = new AnimateHelper();
    private ApiHelper api = new ApiHelper();
      Severity: Minor
      Found in app/src/main/java/com/bedrock/padder/fragment/PresetStoreOnlineFragment.java - About 2 hrs to fix

        Method setLoadingFailed has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private void setLoadingFailed(boolean isFailed) {
        if (isFailed) {
            Log.e(TAG, "Loading failed");
            anim.fadeOut(recyclerView, 0, 200, a);
            anim.fadeOut(recyclerViewLoading, 0, 200, a);
        Severity: Minor
        Found in app/src/main/java/com/bedrock/padder/fragment/PresetStoreOnlineFragment.java - About 1 hr to fix

          Method setAdapter has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              private void setAdapter() {
        if (isPresetDownloading) {
            // attach adapter while its not null
            presetStoreAdapter = new PresetStoreAdapter(
                    online,
          Severity: Minor
          Found in app/src/main/java/com/bedrock/padder/fragment/PresetStoreOnlineFragment.java - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method setLoadingFinished has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public void setLoadingFinished(boolean isFinished) {
        if (isFinished) {
            // finished, hide loading and show recyclerView
            Log.d(TAG, "setLF(true)");
            anim.fadeOut(recyclerViewLoading, 0, 200, a);
          Severity: Minor
          Found in app/src/main/java/com/bedrock/padder/fragment/PresetStoreOnlineFragment.java - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          handler.postDelayed(new Runnable() {
                    @Override
                    public void run() {
                        new MaterialDialog.Builder(a)
                                .title(R.string.preset_store_download_no_connection_dialog_title)
          Severity: Minor
          Found in app/src/main/java/com/bedrock/padder/fragment/PresetStoreOnlineFragment.java and 1 other location - About 35 mins to fix
          app/src/main/java/com/bedrock/padder/activity/FeedbackActivity.java on lines 230..240

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 45.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

              private boolean isConnected(Context context) {
        // returns whether the device is connected to the internet
        ConnectivityManager cm = (ConnectivityManager) context.getSystemService(Context.CONNECTIVITY_SERVICE);

        NetworkInfo activeNetwork = cm.getActiveNetworkInfo();
          Severity: Minor
          Found in app/src/main/java/com/bedrock/padder/fragment/PresetStoreOnlineFragment.java and 2 other locations - About 35 mins to fix
          app/src/main/java/com/bedrock/padder/helper/AdMobHelper.java on lines 59..65
          app/src/main/java/com/bedrock/padder/model/preset/store/Item.java on lines 606..612

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 44.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 6 locations. Consider refactoring.
          Open

                                          new MaterialDialog.Builder(a)
                                        .title(R.string.preset_store_connection_timeout_dialog_title)
                                        .content(R.string.preset_store_connection_timeout_dialog_text)
                                        .contentColorRes(R.color.dark_primary)
                                        .positiveText(R.string.preset_store_connection_timeout_dialog_positive)
          Severity: Major
          Found in app/src/main/java/com/bedrock/padder/fragment/PresetStoreOnlineFragment.java and 5 other locations - About 35 mins to fix
          app/src/main/java/com/bedrock/padder/activity/PresetStoreActivity.java on lines 134..139
          app/src/main/java/com/bedrock/padder/fragment/PresetStoreOnlineFragment.java on lines 251..256
          app/src/main/java/com/bedrock/padder/model/preset/store/Item.java on lines 173..178
          app/src/main/java/com/bedrock/padder/model/preset/store/Item.java on lines 350..355
          app/src/main/java/com/bedrock/padder/model/preset/store/Item.java on lines 464..469

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 44.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 6 locations. Consider refactoring.
          Open

                                              new MaterialDialog.Builder(a)
                                            .title(R.string.preset_store_outdated_version_dialog_title)
                                            .content(R.string.preset_store_outdated_version_dialog_text)
                                            .contentColorRes(R.color.dark_primary)
                                            .positiveText(R.string.preset_store_outdated_version_dialog_positive)
          Severity: Major
          Found in app/src/main/java/com/bedrock/padder/fragment/PresetStoreOnlineFragment.java and 5 other locations - About 35 mins to fix
          app/src/main/java/com/bedrock/padder/activity/PresetStoreActivity.java on lines 134..139
          app/src/main/java/com/bedrock/padder/fragment/PresetStoreOnlineFragment.java on lines 187..192
          app/src/main/java/com/bedrock/padder/model/preset/store/Item.java on lines 173..178
          app/src/main/java/com/bedrock/padder/model/preset/store/Item.java on lines 350..355
          app/src/main/java/com/bedrock/padder/model/preset/store/Item.java on lines 464..469

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 44.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status