Sign upLogin

berict/Tapad

View on GitHub
Star
app/src/main/java/com/bedrock/padder/helper/FileHelper.java

Summary

Maintainability
D
2 days
Test Coverage

File FileHelper.java has 285 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package com.bedrock.padder.helper;

import android.app.Activity;
import android.content.DialogInterface;
import android.os.AsyncTask;
Severity: Minor
Found in app/src/main/java/com/bedrock/padder/helper/FileHelper.java - About 2 hrs to fix

    Consider simplifying this complex logical expression.
    Open

            if (preset != null) {
            String presetName = preset.getTag();
            // preset available
            File folderSound = new File(PROJECT_LOCATION_PRESETS + "/" + presetName + "/sounds");
            File folderTiming = new File(PROJECT_LOCATION_PRESETS + "/" + presetName + "/timing");
    Severity: Critical
    Found in app/src/main/java/com/bedrock/padder/helper/FileHelper.java - About 2 hrs to fix

      Consider simplifying this complex logical expression.
      Open

              if (presetName != null) {
            // preset available
            File folderSound = new File(PROJECT_LOCATION_PRESETS + "/" + presetName + "/sounds");
            File folderTiming = new File(PROJECT_LOCATION_PRESETS + "/" + presetName + "/timing");
            File folderAbout = new File(PROJECT_LOCATION_PRESETS + "/" + presetName + "/about");
      Severity: Critical
      Found in app/src/main/java/com/bedrock/padder/helper/FileHelper.java - About 2 hrs to fix

        Method isPresetAvailable has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public boolean isPresetAvailable(Preset preset) {
        // with sound count check
        if (preset != null) {
            String presetName = preset.getTag();
            // preset available
        Severity: Minor
        Found in app/src/main/java/com/bedrock/padder/helper/FileHelper.java - About 1 hr to fix

          Method doInBackground has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  @Override
        protected Integer doInBackground(Void... params) {
            try {
                FileInputStream fileInputStream = new FileInputStream(zipLocation);
                ZipInputStream zipInputStream = new ZipInputStream(fileInputStream);
          Severity: Minor
          Found in app/src/main/java/com/bedrock/padder/helper/FileHelper.java - About 1 hr to fix

            Method onPostExecute has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    @Override
        protected void onPostExecute(Integer integer) {
            Log.d(TAG, "onPostExecute");
            super.onPostExecute(integer);
            // finished unzipping, delete the original zip file
            Severity: Minor
            Found in app/src/main/java/com/bedrock/padder/helper/FileHelper.java - About 1 hr to fix

              Method onPostExecute has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                      @Override
        protected void onPostExecute(Integer integer) {
            Log.d(TAG, "onPostExecute");
            super.onPostExecute(integer);
            // finished unzipping, delete the original zip file
              Severity: Minor
              Found in app/src/main/java/com/bedrock/padder/helper/FileHelper.java - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method deleteRecursive has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  public boolean deleteRecursive(File fileOrDirectory) {
        boolean recursive = true;
        if (fileOrDirectory.isDirectory())
            if (fileOrDirectory.listFiles() != null && fileOrDirectory.listFiles().length > 0)
            for (File child : fileOrDirectory.listFiles())
              Severity: Minor
              Found in app/src/main/java/com/bedrock/padder/helper/FileHelper.java - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method isPresetAvailable has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  public boolean isPresetAvailable(Preset preset) {
        // with sound count check
        if (preset != null) {
            String presetName = preset.getTag();
            // preset available
              Severity: Minor
              Found in app/src/main/java/com/bedrock/padder/helper/FileHelper.java - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method doInBackground has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                      @Override
        protected Integer doInBackground(Void... params) {
            try {
                FileInputStream fileInputStream = new FileInputStream(zipLocation);
                ZipInputStream zipInputStream = new ZipInputStream(fileInputStream);
              Severity: Minor
              Found in app/src/main/java/com/bedrock/padder/helper/FileHelper.java - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method unzip has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public void unzip(String zipLocation, String targetLocation, String presetName, View parentView, Activity activity, Runnable onFinish) {
              Severity: Minor
              Found in app/src/main/java/com/bedrock/padder/helper/FileHelper.java - About 45 mins to fix

                Method unzip has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    public void unzip(String zipLocation, String targetLocation, String presetName, Activity activity, Runnable onFinish) {
                Severity: Minor
                Found in app/src/main/java/com/bedrock/padder/helper/FileHelper.java - About 35 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                              if (new File(targetLocation + "/" + presetName).delete()) {
                Log.d(TAG, "Successfully removed zip folder");
            } else {
                Log.d(TAG, "Failed to remove zip folder");
            }
                  Severity: Minor
                  Found in app/src/main/java/com/bedrock/padder/helper/FileHelper.java and 1 other location - About 30 mins to fix
                  app/src/main/java/com/bedrock/padder/helper/FileHelper.java on lines 306..310

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 40.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                              if (new File(PROJECT_LOCATION_PRESETS + "/" + presetName).delete()) {
                Log.d(TAG, "Successfully removed preset folder");
            } else {
                Log.d(TAG, "Failed to remove preset folder");
            }
                  Severity: Minor
                  Found in app/src/main/java/com/bedrock/padder/helper/FileHelper.java and 1 other location - About 30 mins to fix
                  app/src/main/java/com/bedrock/padder/helper/FileHelper.java on lines 275..279

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 40.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status