Sign upLogin

berict/Tapad

View on GitHub
Star
app/src/main/java/com/bedrock/padder/helper/SoundHelper.java

Summary

Maintainability
F
4 days
Test Coverage

File SoundHelper.java has 568 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package com.bedrock.padder.helper;

import android.app.Activity;
import android.content.Intent;
import android.content.pm.ShortcutInfo;
Severity: Major
Found in app/src/main/java/com/bedrock/padder/helper/SoundHelper.java - About 1 day to fix

    Method doInBackground has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
    Open

            @Override
        protected Void doInBackground(Void... params) {
            if (previousPreset != null) {
                Log.i(TAG, "Preset \"" + currentPreset.getTag() + "\" loading");
                for (int i = 0; i < 4; i++) {
    Severity: Minor
    Found in app/src/main/java/com/bedrock/padder/helper/SoundHelper.java - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method buttonRevealAnimation has 79 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private void buttonRevealAnimation(final int buttonRectIndex) {
        final Rect buttonRects[] = {
                window.getRect(R.id.btn00, activity),
                window.getRect(R.id.tgl1, activity),
                window.getRect(R.id.tgl2, activity),
    Severity: Major
    Found in app/src/main/java/com/bedrock/padder/helper/SoundHelper.java - About 3 hrs to fix

      Method onPostExecute has 51 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              @Override
        protected void onPostExecute(Void aVoid) {
            if (isCancelled()) {
                onLoadFinish();
            } else {
      Severity: Major
      Found in app/src/main/java/com/bedrock/padder/helper/SoundHelper.java - About 2 hrs to fix

        Method select has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

            private void select(int index) {
        Log.d("SH", "Index selected " + index);
        // index starts from 0
        if (index == -1) {
            // disable all
        Severity: Minor
        Found in app/src/main/java/com/bedrock/padder/helper/SoundHelper.java - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method onPreExecute has 43 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                @Override
        protected void onPreExecute() {
            super.onPreExecute();
            // started loading
            isPresetLoading = true;
        Severity: Minor
        Found in app/src/main/java/com/bedrock/padder/helper/SoundHelper.java - About 1 hr to fix

          Method setDecks has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public void setDecks(int color, int colorDef, Activity activity) {
        Preferences preferences = new Preferences(activity);
        this.color = preferences.getColor();
        this.colorDef = colorDef;
        decks = new Deck[]{
          Severity: Minor
          Found in app/src/main/java/com/bedrock/padder/helper/SoundHelper.java - About 1 hr to fix

            Method doInBackground has 35 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    @Override
        protected Void doInBackground(Void... params) {
            if (previousPreset != null) {
                Log.i(TAG, "Preset \"" + currentPreset.getTag() + "\" loading");
                for (int i = 0; i < 4; i++) {
            Severity: Minor
            Found in app/src/main/java/com/bedrock/padder/helper/SoundHelper.java - About 1 hr to fix

              Method loadColor has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

                  public void loadColor(int color) {
        if (decks != null && currentPreset != null) {
            for (Deck deck : decks) {
                for (Pad pad : deck.getPads()) {
                    if (pad != null) {
              Severity: Minor
              Found in app/src/main/java/com/bedrock/padder/helper/SoundHelper.java - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method selectPattern has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                  private void selectPattern(int index) {
        Log.d("SH", "Index selected " + index);
        // index starts from 0
        if (index == -1) {
            // disable all
              Severity: Minor
              Found in app/src/main/java/com/bedrock/padder/helper/SoundHelper.java - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method onPostExecute has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                      @Override
        protected void onPostExecute(Void aVoid) {
            if (isCancelled()) {
                onLoadFinish();
            } else {
              Severity: Minor
              Found in app/src/main/java/com/bedrock/padder/helper/SoundHelper.java - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method getGesturePadFromArray has 7 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  private GesturePad getGesturePadFromArray(String soundPaths[],
                                              SoundPool soundPool,
                                              int deck,
                                              View buttonView,
                                              int color, int colorDef,
              Severity: Major
              Found in app/src/main/java/com/bedrock/padder/helper/SoundHelper.java - About 50 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                            if (sound != null) {
                                sounds.add(sound);
                                publishProgress();
                            }
                Severity: Major
                Found in app/src/main/java/com/bedrock/padder/helper/SoundHelper.java - About 45 mins to fix

                  Method clear has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public void clear() {
        // clear buttons
        for (Deck deck : decks) {
            for (Pad pad : deck.getPads()) {
                if (pad != null) {
                  Severity: Minor
                  Found in app/src/main/java/com/bedrock/padder/helper/SoundHelper.java - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Identical blocks of code found in 3 locations. Consider refactoring.
                  Open

                          final View buttonViews[] = {
                activity.findViewById(R.id.btn00),
                activity.findViewById(R.id.tgl1),
                activity.findViewById(R.id.tgl2),
                activity.findViewById(R.id.tgl3),
                  Severity: Major
                  Found in app/src/main/java/com/bedrock/padder/helper/SoundHelper.java and 2 other locations - About 4 hrs to fix
                  app/src/main/java/com/bedrock/padder/activity/MainActivity.java on lines 339..365
                  app/src/main/java/com/bedrock/padder/helper/SoundHelper.java on lines 444..470

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 258.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 3 locations. Consider refactoring.
                  Open

                              View buttonViews[] = {
                    activity.findViewById(R.id.btn00),
                    activity.findViewById(R.id.tgl1),
                    activity.findViewById(R.id.tgl2),
                    activity.findViewById(R.id.tgl3),
                  Severity: Major
                  Found in app/src/main/java/com/bedrock/padder/helper/SoundHelper.java and 2 other locations - About 4 hrs to fix
                  app/src/main/java/com/bedrock/padder/activity/MainActivity.java on lines 339..365
                  app/src/main/java/com/bedrock/padder/helper/SoundHelper.java on lines 350..376

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 258.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status