Sign upLogin

berict/Tapad

View on GitHub
Star
app/src/main/java/com/bedrock/padder/model/sound/GesturePad.java

Summary

Maintainability
D
2 days
Test Coverage

GesturePad has 41 methods (exceeds 20 allowed). Consider refactoring.
Open

public class GesturePad extends Pad {

    private Sound up = null;

    private Sound right = null;
Severity: Minor
Found in app/src/main/java/com/bedrock/padder/model/sound/GesturePad.java - About 5 hrs to fix

    Method initListener has 115 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private void initListener() {
        normal.setSoundListener(new Sound.SoundListener() {
            @Override
            public void onSoundStart(Sound sound, int playingThreadCount) {
                threadCount++;
    Severity: Major
    Found in app/src/main/java/com/bedrock/padder/model/sound/GesturePad.java - About 4 hrs to fix

      File GesturePad.java has 265 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      package com.bedrock.padder.model.sound;

import android.app.Activity;
import android.util.Log;
import android.view.View;
      Severity: Minor
      Found in app/src/main/java/com/bedrock/padder/model/sound/GesturePad.java - About 2 hrs to fix

        Method setPad has 44 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            @Override
    void setPad() {
        if (normal != null && view != null && color != 0 && colorDef != 0 && activity != null) {
            // initialized check, normal should be not null
            view.setOnTouchListener(new OnSwipeTouchListener(activity) {
        Severity: Minor
        Found in app/src/main/java/com/bedrock/padder/model/sound/GesturePad.java - About 1 hr to fix

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                  left.setSoundListener(new Sound.SoundListener() {
            @Override
            public void onSoundStart(Sound sound, int playingThreadCount) {
                threadCount++;
                if (threadCount == 1 && !padColorOnPlay) {
          Severity: Major
          Found in app/src/main/java/com/bedrock/padder/model/sound/GesturePad.java and 3 other locations - About 1 hr to fix
          app/src/main/java/com/bedrock/padder/model/sound/GesturePad.java on lines 75..100
          app/src/main/java/com/bedrock/padder/model/sound/GesturePad.java on lines 102..127
          app/src/main/java/com/bedrock/padder/model/sound/GesturePad.java on lines 129..154

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 100.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                  down.setSoundListener(new Sound.SoundListener() {
            @Override
            public void onSoundStart(Sound sound, int playingThreadCount) {
                threadCount++;
                if (threadCount == 1 && !padColorOnPlay) {
          Severity: Major
          Found in app/src/main/java/com/bedrock/padder/model/sound/GesturePad.java and 3 other locations - About 1 hr to fix
          app/src/main/java/com/bedrock/padder/model/sound/GesturePad.java on lines 75..100
          app/src/main/java/com/bedrock/padder/model/sound/GesturePad.java on lines 102..127
          app/src/main/java/com/bedrock/padder/model/sound/GesturePad.java on lines 156..181

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 100.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                  up.setSoundListener(new Sound.SoundListener() {
            @Override
            public void onSoundStart(Sound sound, int playingThreadCount) {
                threadCount++;
                if (threadCount == 1 && !padColorOnPlay) {
          Severity: Major
          Found in app/src/main/java/com/bedrock/padder/model/sound/GesturePad.java and 3 other locations - About 1 hr to fix
          app/src/main/java/com/bedrock/padder/model/sound/GesturePad.java on lines 102..127
          app/src/main/java/com/bedrock/padder/model/sound/GesturePad.java on lines 129..154
          app/src/main/java/com/bedrock/padder/model/sound/GesturePad.java on lines 156..181

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 100.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                  right.setSoundListener(new Sound.SoundListener() {
            @Override
            public void onSoundStart(Sound sound, int playingThreadCount) {
                threadCount++;
                if (threadCount == 1 && !padColorOnPlay) {
          Severity: Major
          Found in app/src/main/java/com/bedrock/padder/model/sound/GesturePad.java and 3 other locations - About 1 hr to fix
          app/src/main/java/com/bedrock/padder/model/sound/GesturePad.java on lines 75..100
          app/src/main/java/com/bedrock/padder/model/sound/GesturePad.java on lines 129..154
          app/src/main/java/com/bedrock/padder/model/sound/GesturePad.java on lines 156..181

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 100.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              @Override
    void unload() {
        Sound sounds[] = {
                up, right, down, left
        };
          Severity: Minor
          Found in app/src/main/java/com/bedrock/padder/model/sound/GesturePad.java and 1 other location - About 40 mins to fix
          app/src/main/java/com/bedrock/padder/model/sound/GesturePad.java on lines 307..319

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 51.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              @Override
    public void stop() {
        Sound sounds[] = {
                up, right, down, left
        };
          Severity: Minor
          Found in app/src/main/java/com/bedrock/padder/model/sound/GesturePad.java and 1 other location - About 40 mins to fix
          app/src/main/java/com/bedrock/padder/model/sound/GesturePad.java on lines 293..305

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 51.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status