Sign upLogin

berict/Tapad

View on GitHub
Star
app/src/main/java/com/bedrock/padder/model/sound/Pad.java

Summary

Maintainability
F
5 days
Test Coverage

Method setPadColor has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
Open

    void setPadColor() {
        setPadColor(color);

        switch (PAD_PATTERN) {
            case 1:
Severity: Minor
Found in app/src/main/java/com/bedrock/padder/model/sound/Pad.java - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method setPadColorToDefault has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
Open

    void setPadColorToDefault() {
        switch (PAD_PATTERN) {
            case 1:
                // 4 side
                if (row - 1 > 0) {
Severity: Minor
Found in app/src/main/java/com/bedrock/padder/model/sound/Pad.java - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Pad has 40 methods (exceeds 20 allowed). Consider refactoring.
Open

public class Pad {

    protected Sound normal = null;

    protected View view = null;
Severity: Minor
Found in app/src/main/java/com/bedrock/padder/model/sound/Pad.java - About 5 hrs to fix

    File Pad.java has 387 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    package com.bedrock.padder.model.sound;

import android.app.Activity;
import android.content.res.Resources;
import android.os.Handler;
    Severity: Minor
    Found in app/src/main/java/com/bedrock/padder/model/sound/Pad.java - About 5 hrs to fix

      Method setPad has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          void setPad() {
        // set the onTouchListener
        if (view != null && color != 0 && colorDef != 0 && activity != null) {
            // initialized check
            view.setOnTouchListener(new OnSwipeTouchListener(activity) {
      Severity: Minor
      Found in app/src/main/java/com/bedrock/padder/model/sound/Pad.java - About 2 hrs to fix

        Method setPadColor has 47 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            void setPadColor() {
        setPadColor(color);

        switch (PAD_PATTERN) {
            case 1:
        Severity: Minor
        Found in app/src/main/java/com/bedrock/padder/model/sound/Pad.java - About 1 hr to fix

          Method setPadColorToDefault has 46 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              void setPadColorToDefault() {
        switch (PAD_PATTERN) {
            case 1:
                // 4 side
                if (row - 1 > 0) {
          Severity: Minor
          Found in app/src/main/java/com/bedrock/padder/model/sound/Pad.java - About 1 hr to fix

            Method setPadColor has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

                void setPadColor(int row, int column, final int color, int duration, int delay) {
        if (row * column != 0) {
            final View pad = getViewFromId("btn" + column + row, activity);
            if (getBackgroundColor(pad) != getColor(color, activity) && getBackgroundColor(pad) != getColor(color, activity)) {
                // was not pressed
            Severity: Minor
            Found in app/src/main/java/com/bedrock/padder/model/sound/Pad.java - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method setPadColor has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                void setPadColor(int row, int column, final int color, int duration, int delay) {
            Severity: Minor
            Found in app/src/main/java/com/bedrock/padder/model/sound/Pad.java - About 35 mins to fix

              Method setPadColor has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  void setPadColor(int row, int column, final int color, int duration) {
        if (row * column != 0) {
            final View pad = getViewFromId("btn" + column + row, activity);
            if (getBackgroundColor(pad) != getColor(color, activity) && getBackgroundColor(pad) != getColor(color, activity)) {
                // was not pressed
              Severity: Minor
              Found in app/src/main/java/com/bedrock/padder/model/sound/Pad.java - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method setPadColorToDefault has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  void setPadColorToDefault(boolean isForced) {
        if (isForced && view != null) {
            // forced change
            setPadColor(colorDef);
        } else {
              Severity: Minor
              Found in app/src/main/java/com/bedrock/padder/model/sound/Pad.java - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      switch (PAD_PATTERN) {
            case 1:
                // 4 side
                if (row - 1 > 0) {
                    // left available
              Severity: Major
              Found in app/src/main/java/com/bedrock/padder/model/sound/Pad.java and 1 other location - About 7 hrs to fix
              app/src/main/java/com/bedrock/padder/model/sound/Pad.java on lines 155..208

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 476.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      switch (PAD_PATTERN) {
            case 1:
                // 4 side
                if (row - 1 > 0) {
                    // left available
              Severity: Major
              Found in app/src/main/java/com/bedrock/padder/model/sound/Pad.java and 1 other location - About 7 hrs to fix
              app/src/main/java/com/bedrock/padder/model/sound/Pad.java on lines 279..332

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 476.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status