Sign upLogin

beyond-blockchain/bbclib-go

View on GitHub
Star

Showing 32 of 32 total issues

Function Deserialize has 6 return statements (exceeds 4 allowed).
Open

func Deserialize(dat []byte) (*BBcTransaction, error) {
    buf := bytes.NewBuffer(dat)

    formatType, err := Get2byte(buf)
    if err != nil {
Severity: Major
Found in bbclib.go - About 40 mins to fix

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        if p.Asset != nil {
        ast, er := p.Asset.Pack()
        if er != nil {
            return nil, er
        }
    Severity: Major
    Found in relation.go and 3 other locations - About 40 mins to fix
    event.go on lines 190..201
    relation.go on lines 178..189
    relation.go on lines 191..202

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 109.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

            if p.AssetRaw != nil {
            ast, er := p.AssetRaw.Pack()
            if er != nil {
                return nil, er
            }
    Severity: Major
    Found in relation.go and 3 other locations - About 40 mins to fix
    event.go on lines 190..201
    relation.go on lines 164..175
    relation.go on lines 191..202

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 109.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        if p.Asset != nil {
        ast, err := p.Asset.Pack()
        if err != nil {
            return nil, err
        }
    Severity: Major
    Found in event.go and 3 other locations - About 40 mins to fix
    relation.go on lines 164..175
    relation.go on lines 178..189
    relation.go on lines 191..202

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 109.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

            if p.AssetHash != nil {
            ast, er := p.AssetHash.Pack()
            if er != nil {
                return nil, er
            }
    Severity: Major
    Found in relation.go and 3 other locations - About 40 mins to fix
    event.go on lines 190..201
    relation.go on lines 164..175
    relation.go on lines 178..189

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 109.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func (k *KeyPair) OutputPublicKeyPem() (string, error) {
    der := k.OutputPublicKeyDer()
    if der == nil {
        return "", errors.New("failed to export the public key to pem format")
    }
    Severity: Minor
    Found in keypair.go and 1 other location - About 35 mins to fix
    keypair.go on lines 263..275

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 106.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func (k *KeyPair) OutputPem() (string, error) {
    der := k.OutputDer()
    if der == nil {
        return "", errors.New("failed to export the private key to pem format")
    }
    Severity: Minor
    Found in keypair.go and 1 other location - About 35 mins to fix
    keypair.go on lines 287..299

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 106.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method KeyPair.ConvertFromPem has 5 return statements (exceeds 4 allowed).
    Open

    func (k *KeyPair) ConvertFromPem(pemstr string, compressionMode int) error {
    block, _ := pem.Decode([]byte(pemstr))
    if block == nil {
        return errors.New("invalid PEM format")
    }
    Severity: Major
    Found in keypair.go - About 35 mins to fix

      Method BBcSignature.Unpack has 5 return statements (exceeds 4 allowed).
      Open

      func (p *BBcSignature) Unpack(dat *[]byte) error {
    var err error
    buf := bytes.NewBuffer(*dat)

    keyType, err := Get4byte(buf)
      Severity: Major
      Found in signature.go - About 35 mins to fix

        Method BBcEvent.Pack has 5 return statements (exceeds 4 allowed).
        Open

        func (p *BBcEvent) Pack() ([]byte, error) {
    if len(p.OptionApprovers) != int(p.OptionApproverNumDenominator) {
        return nil, errors.New("num of option approvers must be equal to OptionApproverNumDenominator")
    }
    if p.AssetGroupID == nil {
        Severity: Major
        Found in event.go - About 35 mins to fix

          Method BBcPointer.Unpack has 5 return statements (exceeds 4 allowed).
          Open

          func (p *BBcPointer) Unpack(dat *[]byte) error {
    if p.IdLengthConf == nil {
        p.IdLengthConf = &BBcIdConfig{}
    }
          Severity: Major
          Found in pointer.go - About 35 mins to fix

            Method BBcTransaction.packBase has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
            Open

            func (p *BBcTransaction) packBase(buf *bytes.Buffer) error {
    Put4byte(buf, p.Version)
    if p.Timestamp == 0 {
        p.Timestamp = time.Now().UnixNano() / int64(time.Microsecond)
    }
            Severity: Minor
            Found in transaction.go - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language