Sign upLogin

beyond-blockchain/bbclib-go

View on GitHub
Star
transaction.go

Summary

Maintainability
C
1 day
Test Coverage

BBcTransaction has 25 methods (exceeds 20 allowed). Consider refactoring.
Open

    BBcTransaction struct {
        digestCalculating     bool
        IdLengthConf          BBcIdConfig
        TransactionID         []byte
        TransactionBaseDigest []byte
Severity: Minor
Found in transaction.go - About 2 hrs to fix

    File transaction.go has 507 lines of code (exceeds 500 allowed). Consider refactoring.
    Open

    /*
Copyright (c) 2018 Zettant Inc.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
    Severity: Minor
    Found in transaction.go - About 2 hrs to fix

      Method BBcTransaction.packBase has 55 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (p *BBcTransaction) packBase(buf *bytes.Buffer) error {
    Put4byte(buf, p.Version)
    if p.Timestamp == 0 {
        p.Timestamp = time.Now().UnixNano() / int64(time.Microsecond)
    }
      Severity: Minor
      Found in transaction.go - About 1 hr to fix

        Method BBcTransaction.packBase has 9 return statements (exceeds 4 allowed).
        Open

        func (p *BBcTransaction) packBase(buf *bytes.Buffer) error {
    Put4byte(buf, p.Version)
    if p.Timestamp == 0 {
        p.Timestamp = time.Now().UnixNano() / int64(time.Microsecond)
    }
        Severity: Major
        Found in transaction.go - About 55 mins to fix

          Method BBcTransaction.Unpack has 8 return statements (exceeds 4 allowed).
          Open

          func (p *BBcTransaction) Unpack(dat *[]byte) error {
    buf := bytes.NewBuffer(*dat)

    if err := p.unpackHeader(buf); err != nil {
        return err
          Severity: Major
          Found in transaction.go - About 50 mins to fix

            Method BBcTransaction.Pack has 6 return statements (exceeds 4 allowed).
            Open

            func (p *BBcTransaction) Pack() ([]byte, error) {
    if !p.digestCalculating && p.TransactionID == nil {
        p.Digest()
    }
            Severity: Major
            Found in transaction.go - About 40 mins to fix

              Method BBcTransaction.packBase has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
              Open

              func (p *BBcTransaction) packBase(buf *bytes.Buffer) error {
    Put4byte(buf, p.Version)
    if p.Timestamp == 0 {
        p.Timestamp = time.Now().UnixNano() / int64(time.Microsecond)
    }
              Severity: Minor
              Found in transaction.go - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  if p.Crossref != nil {
        dat, err := p.Crossref.Pack()
        if err != nil {
            return err
        }
              Severity: Minor
              Found in transaction.go and 1 other location - About 45 mins to fix
              transaction.go on lines 391..403

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 115.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  if p.Witness != nil {
        dat, err := p.Witness.Pack()
        if err != nil {
            return err
        }
              Severity: Minor
              Found in transaction.go and 1 other location - About 45 mins to fix
              transaction.go on lines 330..342

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 115.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status