Method has too many lines. [32/10] Open
def remote_list
cli.say 'Downloading genome list'
current_page = 1
total_pages = 1
ds = {}
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.
Assignment Branch Condition size for remote_list is too high. [35.28/15] Open
def remote_list
cli.say 'Downloading genome list'
current_page = 1
total_pages = 1
ds = {}
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric
Method remote_list
has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring. Open
def remote_list
cli.say 'Downloading genome list'
current_page = 1
total_pages = 1
ds = {}
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method remote_list
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
def remote_list
cli.say 'Downloading genome list'
current_page = 1
total_pages = 1
ds = {}
- Create a ticketCreate a ticket
Put empty method definitions on a single line. Open
def cli_task_flags(_opt)
end
- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
This cop checks for the formatting of empty method definitions.
By default it enforces empty method definitions to go on a single
line (compact style), but it can be configured to enforce the end
to go on its own line (expanded style).
Note: A method definition is not considered empty if it contains comments.
Example: EnforcedStyle: compact (default)
# bad
def foo(bar)
end
def self.foo(bar)
end
# good
def foo(bar); end
def foo(bar)
# baz
end
def self.foo(bar); end
Example: EnforcedStyle: expanded
# bad
def foo(bar); end
def self.foo(bar); end
# good
def foo(bar)
end
def self.foo(bar)
end