Sign upLogin

bio-miga/miga

View on GitHub
Star
lib/miga/dataset/result/ignore.rb

Summary

Maintainability
A
0 mins
Test Coverage
A
97%

Method has too many lines. [15/10]
Open

  def ignore_by_type?(task, type)
    return false if force_task?(task)

    test, list =
      case type.to_sym
Severity: Minor
Found in lib/miga/dataset/result/ignore.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Cyclomatic complexity for ignore_by_type? is too high. [7/6]
Open

  def ignore_by_type?(task, type)
    return false if force_task?(task)

    test, list =
      case type.to_sym
Severity: Minor
Found in lib/miga/dataset/result/ignore.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Assignment Branch Condition size for ignore_by_type? is too high. [15.52/15]
Open

  def ignore_by_type?(task, type)
    return false if force_task?(task)

    test, list =
      case type.to_sym
Severity: Minor
Found in lib/miga/dataset/result/ignore.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Redundant return detected.
Open

    return :execute
Severity: Minor
Found in lib/miga/dataset/result/ignore.rb by rubocop

This cop checks for redundant return expressions.

Example:

def test
  return something
end

def test
  one
  two
  three
  return something
end

It should be extended to handle methods whose body is if/else or a case expression with a default branch.

Missing top-level module documentation comment.
Open

module MiGA::Dataset::Result::Ignore
Severity: Minor
Found in lib/miga/dataset/result/ignore.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Avoid the use of double negation (!!).
Open

    !!metadata["run_#{task}"]
Severity: Minor
Found in lib/miga/dataset/result/ignore.rb by rubocop

This cop checks for uses of double negation (!!) to convert something to a boolean value. As this is both cryptic and usually redundant, it should be avoided.

Example:

# bad
!!something

# good
!something.nil?

Please, note that when something is a boolean value !!something and !something.nil? are not the same thing. As you're unlikely to write code that can accept values of any type this is rarely a problem in practice.

There are no issues that match your filters.

Category
Status