bizley/yii2-podium

Avoid too many return statements within this method.

Open

                        return $this->redirect(['forum/show', 'id' => $model->id]);

Avoid too many return statements within this method.

Open

        return Html::tag('span',
            Html::tag('span', '', ['class' => 'glyphicon glyphicon-warning-sign'])
            . ' ' . Yii::t('podium/view', "Sorry! We can not save new forums' order."),
            ['class' => 'text-danger']
        );

Avoid too many return statements within this method.

Open

            return $this->redirect(['forum/maintenance']);

Avoid too many return statements within this method.

Open

        return false;

The method prepareQuery has a boolean flag argument $topics, which is a certain sign of a Single Responsibility Principle violation.

Open

    protected function prepareQuery($query, $topics = false)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

Avoid too many return statements within this method.

Open

            return Html::tag('span',
                Html::tag('span', '', ['class' => 'glyphicon glyphicon-ok-circle'])
                . ' ' . Yii::t('podium/view', "New categories' order has been saved."),
                ['class' => 'text-success']
            );

Avoid too many return statements within this method.

Open

            return $this->returnError($e->getMessage(), __METHOD__,
                Yii::t('podium/flash', 'Error during table foreign key {name} adding', [
                    'name' => $this->getForeignName($key)
                ])
            );

Avoid too many return statements within this method.

Open

        return Json::encode($data);

The method search has a boolean flag argument $mods, which is a certain sign of a Single Responsibility Principle violation.

Open

    public function search($params, $active = false, $mods = false)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

The method warning has a boolean flag argument $removeAfterAccess, which is a certain sign of a Single Responsibility Principle violation.

Open

    public function warning($message, $removeAfterAccess = true)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

The method podiumUserTag has a boolean flag argument $simple, which is a certain sign of a Single Responsibility Principle violation.

Open

    public static function podiumUserTag($name, $role, $id = null, $slug = null, $simple = false)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

The method search has a boolean flag argument $active, which is a certain sign of a Single Responsibility Principle violation.

Open

    public function search($params, $active = false, $mods = false)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

The method success has a boolean flag argument $removeAfterAccess, which is a certain sign of a Single Responsibility Principle violation.

Open

    public function success($message, $removeAfterAccess = true)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

The method alert has a boolean flag argument $removeAfterAccess, which is a certain sign of a Single Responsibility Principle violation.

Open

    public function alert($message, $removeAfterAccess = true)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

The method ok has a boolean flag argument $removeAfterAccess, which is a certain sign of a Single Responsibility Principle violation.

Open

    public function ok($message, $removeAfterAccess = true)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

The method error has a boolean flag argument $removeAfterAccess, which is a certain sign of a Single Responsibility Principle violation.

Open

    public function error($message, $removeAfterAccess = true)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

The method getPodiumTag has a boolean flag argument $simple, which is a certain sign of a Single Responsibility Principle violation.

Open

    public function getPodiumTag($simple = false)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

The method podiumThumb has a boolean flag argument $up, which is a certain sign of a Single Responsibility Principle violation.

Open

    public function podiumThumb($up = true, $count = 0)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

The method danger has a boolean flag argument $removeAfterAccess, which is a certain sign of a Single Responsibility Principle violation.

Open

    public function danger($message, $removeAfterAccess = true)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

The method can has a boolean flag argument $allowCaching, which is a certain sign of a Single Responsibility Principle violation.

Open

    public static function can($permissionName, $params = [], $allowCaching = true)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}