bizley/yii2-podium

Avoid too many return statements within this method.

Open

        return false;

Avoid too many return statements within this method.

Open

        return $this->redirect(['admin/members']);

The method podiumEdit has a boolean flag argument $isFirstPost, which is a certain sign of a Single Responsibility Principle violation.

Open

    public function podiumEdit($isFirstPost = false)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

The method search has a boolean flag argument $mods, which is a certain sign of a Single Responsibility Principle violation.

Open

    public function search($params, $active = false, $mods = false)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

The method success has a boolean flag argument $removeAfterAccess, which is a certain sign of a Single Responsibility Principle violation.

Open

    public function success($message, $removeAfterAccess = true)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

The method can has a boolean flag argument $allowCaching, which is a certain sign of a Single Responsibility Principle violation.

Open

    public static function can($permissionName, $params = [], $allowCaching = true)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

The method error has a boolean flag argument $removeAfterAccess, which is a certain sign of a Single Responsibility Principle violation.

Open

    public function error($message, $removeAfterAccess = true)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

The method ok has a boolean flag argument $removeAfterAccess, which is a certain sign of a Single Responsibility Principle violation.

Open

    public function ok($message, $removeAfterAccess = true)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

The method warning has a boolean flag argument $removeAfterAccess, which is a certain sign of a Single Responsibility Principle violation.

Open

    public function warning($message, $removeAfterAccess = true)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

The method markSeen has a boolean flag argument $updateCounters, which is a certain sign of a Single Responsibility Principle violation.

Open

    public function markSeen($updateCounters = true)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

The method info has a boolean flag argument $removeAfterAccess, which is a certain sign of a Single Responsibility Principle violation.

Open

    public function info($message, $removeAfterAccess = true)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

Avoid too many return statements within this method.

Open

        return Html::tag('span',
            Html::tag('span', '', ['class' => 'glyphicon glyphicon-warning-sign'])
            . ' ' . Yii::t('podium/view', "Sorry! We can not save new categories' order."),
            ['class' => 'text-danger']
        );

Avoid too many return statements within this method.

Open

            return $this->redirect(['forum/maintenance']);

Avoid too many return statements within this method.

Open

                        return $this->redirect(['forum/show', 'id' => $model->id]);

Avoid too many return statements within this method.

Open

            return Html::tag('span',
                Html::tag('span', '', ['class' => 'glyphicon glyphicon-ok-circle'])
                . ' ' . Yii::t('podium/view', "New forums' order has been saved."),
                ['class' => 'text-success']
            );

Avoid too many return statements within this method.

Open

                    return $this->redirect([
                        'forum/thread',
                        'cid' => $post->forum->category->id,
                        'fid' => $post->forum->id,
                        'id' => $post->thread->id,

The method search has a boolean flag argument $onlyVisible, which is a certain sign of a Single Responsibility Principle violation.

Open

    public function search($categoryId = null, $onlyVisible = false)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

The method verify has a boolean flag argument $guest, which is a certain sign of a Single Responsibility Principle violation.

Open

    public static function verify($categoryId = null, $id = null, $slug = null, $guest = true)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

The method getPodiumTag has a boolean flag argument $simple, which is a certain sign of a Single Responsibility Principle violation.

Open

    public function getPodiumTag($simple = false)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

The method podiumThumb has a boolean flag argument $up, which is a certain sign of a Single Responsibility Principle violation.

Open

    public function podiumThumb($up = true, $count = 0)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}