bizley/yii2-podium

Avoid too many return statements within this method.

Open

        return [
            false,
            Yii::t('podium/flash', 'The password reset link has been sent to your e-mail address.'),
            true
        ];

Avoid too many return statements within this method.

Open

                return $this->module->goPodium();

Avoid too many return statements within this method.

Open

        return $this->render('deletepoll', ['model' => $poll]);

Avoid too many return statements within this method.

Open

                    return Json::encode($data);

Avoid too many return statements within this method.

Open

        return false;

Avoid too many return statements within this method.

Open

        return $this->controller->redirect(['admin/members']);

Avoid too many return statements within this method.

Open

        return $this->redirect(['members/view', 'id' => $model->id, 'slug' => $model->podiumSlug]);

Avoid too many return statements within this method.

Open

        return $this->render('post', [
            'replyFor' => $replyFor,
            'preview' => $preview,
            'model' => $model,
            'thread' => $thread,

The method deletedUserTag has a boolean flag argument $simple, which is a certain sign of a Single Responsibility Principle violation.

Open

    public static function deletedUserTag($simple = false)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

The method podiumUserTag has a boolean flag argument $simple, which is a certain sign of a Single Responsibility Principle violation.

Open

    public static function podiumUserTag($name, $role, $id = null, $slug = null, $simple = false)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

The method danger has a boolean flag argument $removeAfterAccess, which is a certain sign of a Single Responsibility Principle violation.

Open

    public function danger($message, $removeAfterAccess = true)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

Avoid too many return statements within this method.

Open

        return $this->render('deletepost', ['model' => $post]);

Avoid too many return statements within this method.

Open

        return Json::encode($data);

Avoid too many return statements within this method.

Open

        return $this->render('report', ['model' => $model, 'post' => $post]);

Avoid too many return statements within this method.

Open

        return true;

The method search has a boolean flag argument $active, which is a certain sign of a Single Responsibility Principle violation.

Open

    public function search($params, $active = false, $mods = false)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

The method prepareQuery has a boolean flag argument $topics, which is a certain sign of a Single Responsibility Principle violation.

Open

    protected function prepareQuery($query, $topics = false)

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    public function bar($flag = true) {
    }
}

Avoid too many return statements within this method.

Open

                        return Json::encode($data);

Avoid too many return statements within this method.

Open

        return $this->render('moveposts', [
            'model' => $thread,
            'list' => $list,
            'options' => $options,
            'listforum' => $listforum,

Avoid too many return statements within this method.

Open

            return Html::tag('span',
                Html::tag('span', '', ['class' => 'glyphicon glyphicon-ok-circle'])
                . ' ' . Yii::t('podium/view', "New categories' order has been saved."),
                ['class' => 'text-success']
            );