Showing 298 of 329 total issues
File Config.php
has 305 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
* This file is part of PHPDebugConsole
*
AbstractValue
has 22 functions (exceeds 20 allowed). Consider refactoring. Open
abstract class AbstractValue extends AbstractComponent
{
/** @var Debug */
public $debug;
Value
has 22 functions (exceeds 20 allowed). Consider refactoring. Open
class Value extends TextValue
{
/** @var string */
protected $escapeReset = "\e[0m";
Function toStringCheck
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
protected function toStringCheck(Error $error)
{
if (PHP_VERSION_ID >= 70400) {
return;
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function pathGet
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
public static function pathGet(&$array, $path, $default = null)
{
$path = \array_reverse(self::pathToArray($path));
$curPath = array();
while ($path) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function each
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
public function each($requests, array $config = array())
{
if (!isset($config['concurrency'])) {
$config['concurrency'] = 25;
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function colKeysMerge
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
private static function colKeysMerge(array $curRowKeys, array $colKeys)
{
/** @var list<array-key> */
$newKeys = array();
$count = \count($curRowKeys);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method errorFactory
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
protected function errorFactory(self $handler, $errType, $errMsg, $file, $line, $vars = array())
Function valueFromReflection
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
private function valueFromReflection(array $propInfo, Abstraction $abs, ReflectionProperty $refProperty)
{
$refProperty->setAccessible(true); // only accessible via reflection
$obj = $abs->getSubject();
if ($propInfo['isVirtual']) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function unsubscribeFromPriority
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
protected function unsubscribeFromPriority($eventName, $callable, $priority, $onlyOnce)
{
$search = \array_filter(array(
'callable' => $callable,
'onlyOnce' => $onlyOnce,
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function pathSet
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
public static function pathSet(array &$array, $path, $val)
{
$path = \array_reverse(self::pathToArray($path));
while ($path) {
$key = \array_pop($path);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method __construct
has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
public function __construct(Debug $subject, $method, $args = array(), $meta = array(), $defaultArgs = array(), $argsToMeta = array())
Function tabValuesFinish
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
private function tabValuesFinish($vals, Abstraction $abs)
{
$strLenDiff = $abs['strlen'] - $abs['strlenValue'];
if ($strLenDiff) {
$vals['valRaw'] .= '<span class="maxlen">… ' . $strLenDiff . ' more bytes (not logged)</span>';
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Similar blocks of code found in 2 locations. Consider refactoring. Open
public static function assertType($value, $type, $allowNull = true)
{
if ($allowNull && $value === null) {
return;
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 93.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
protected static function assertType($value, $type, $allowNull = true)
{
if ($allowNull && $value === null) {
return;
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 93.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function expandGroupObjNext
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
function expandGroupObjNext ($toggle, $classTarget, $evtTarget, icon, eventNameDone) {
Method dumpExtendsImplements
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
private function dumpExtendsImplements(array $listOrTree, $label, $treeClass, $itemClass, array $interfacesCollapse = array())
Method bindParam
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
public function bindParam($parameter, &$variable, $dataType = PdoBase::PARAM_STR, $length = null, $driverOptions = null)
Method bindColumn
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
public function bindColumn($column, &$param, $type = null, $maxLen = null, $driverData = null)
Function createFileLinkReplace
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
function createFileLinkReplace ($string, matches, text, remove, isUpdate) {