Showing 153 of 170 total issues
Function clearErrorsHelper
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
private function clearErrorsHelper(&$log, $clear = true)
{
$errorsNotCleared = array();
foreach ($log as $k => $logEntry) {
if (\in_array($logEntry['method'], array('error', 'warn'), true) === false) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function buildSubscriberInfoFromValues
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
private static function buildSubscriberInfoFromValues($values)
{
$subscriberInfo = array(
'callable' => null,
'onlyOnce' => false,
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getInterfaces
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
protected function getInterfaces(ReflectionClass $reflector)
{
$interfaces = array();
$remove = array();
foreach ($reflector->getInterfaces() as $classname => $refClass) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function findGroupEnd
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
private function findGroupEnd($id, $logEntries)
{
$depth = 0;
$inGroup = false;
foreach ($logEntries as $key => $logEntry) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function getLastFrame
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
private function getLastFrame()
{
\ini_set('xdebug.var_display_max_depth', 3);
$backtrace = \xdebug_get_function_stack();
$backtrace = \array_reverse($backtrace);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function autoArgsTest
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
private function autoArgsTest($file, $functionStartLine, $callerLine)
{
if ($file === null) {
return false;
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function findEvalCode
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
private static function findEvalCode(array $backtrace, $index)
{
$backtrace = \array_slice($backtrace, $index);
$lines = false;
foreach ($backtrace as $frame) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method timeLogEntry
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function timeLogEntry($method, array $args)
{
$logEntry = new LogEntry(
$this->debug,
$method,
Method timeLog
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function timeLog($label = null, $args = null)
{
$logEntry = new LogEntry(
$this->debug,
__FUNCTION__,
Function debugEnhanceDefault
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
function debugEnhanceDefault ($node) {
$node.each(function () {
var $self = $(this)
if ($self.hasClass('debug')) {
// console.warn('debugEnhance() : .debug')
Method buildFatalBacktrace
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function buildFatalBacktrace($trace)
{
$cfgWas = $this->debug->setCfg(array(
'maxDepth' => 0,
// Don't inspect objects when dumping trace arguments... potentially huge objects
Method installDependencies
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
private static function installDependencies()
{
$composer = $GLOBALS['argv'][0];
$info = array(
'haveSlevomat' => false,
Method logInput
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function logInput($method, $contentType)
{
$request = $this->debug->serverRequest;
$input = $this->debug->utility->getStreamContents($request->getBody());
$methodHasBody = $this->debug->utility->httpMethodHasBody($method);
Similar blocks of code found in 2 locations. Consider refactoring. Open
public static function mergeDeep(array $arrayDef, $array2)
{
$mergeArrays = \func_get_args();
\array_shift($mergeArrays);
while ($mergeArrays) {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 100.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
public static function diffAssocRecursive(array $array, $arrays)
{
$arrays = \func_get_args();
\array_shift($arrays);
while ($arrays) {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 100.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function tippyContent
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
function tippyContent (reference) {
var $ref = $(reference)
var attributes
var title
if ($ref.hasClass('fa-hashtag')) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function each
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
public function each($requests, array $config = array())
{
if (!isset($config['concurrency'])) {
$config['concurrency'] = 25;
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function searchRecursive
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
public static function searchRecursive($value, array $array, $inclKeys = false)
{
$key = \array_search($value, $array, true);
if ($key !== false) {
return array($key);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function pathGet
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
public static function pathGet(&$array, $path, $default = null)
{
$path = \array_reverse(self::pathToArray($path));
$curPath = array();
while ($path) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function toStringCheck
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
protected function toStringCheck(Error $error)
{
if (PHP_VERSION_ID >= 70400) {
return;
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"