src/CurlHttpMessage/Exception/RequestException.php
Define a constant instead of duplicating this literal "Psr\Http\Message\ResponseInterface" 3 times. Open
Open
\bdk\Debug\Utility::assertType($response, 'Psr\Http\Message\ResponseInterface');
- Read upRead up
- Exclude checks
Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.
On the other hand, constants can be referenced from many places, but only need to be updated in a single place.
Noncompliant Code Example
With the default threshold of 3:
function run() { prepare('action1'); // Non-Compliant - 'action1' is duplicated 3 times execute('action1'); release('action1'); }
Compliant Solution
ACTION_1 = 'action1'; function run() { prepare(ACTION_1); execute(ACTION_1); release(ACTION_1); }
Exceptions
To prevent generating some false-positives, literals having less than 5 characters are excluded.
Unexpected tabs found. Open
Open
/** @var RequestInterface */
- Exclude checks
Unexpected tabs found. Open
Open
/**
- Exclude checks
Unexpected tabs found. Open
Open
}
- Exclude checks
Unexpected tabs found. Open
Open
}
- Exclude checks
Unexpected tabs found. Open
Open
/**
- Exclude checks
Unexpected tabs found. Open
Open
{
- Exclude checks
Unexpected tabs found. Open
Open
private $request;
- Exclude checks
Unexpected tabs found. Open
Open
public function __construct($message, RequestInterface $request, $response = null, $prevException = null)
- Exclude checks
Unexpected tabs found. Open
Open
public function getRequest()
- Exclude checks
Unexpected tabs found. Open
Open
{
- Exclude checks
Unexpected tabs found. Open
Open
return $this->request;
- Exclude checks