Sign upLogin

bkdotcom/PHPDebugConsole

View on GitHub
Star
src/Debug/Collector/Pdo/Statement.php

Summary

Maintainability
A
1 hr
Test Coverage
A
97%

Method bindParam has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function bindParam($parameter, &$variable, $dataType = PdoBase::PARAM_STR, $length = null, $driverOptions = null)
Severity: Minor
Found in src/Debug/Collector/Pdo/Statement.php - About 35 mins to fix

    Method bindColumn has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function bindColumn($column, &$param, $type = null, $maxLen = null, $driverData = null)
    Severity: Minor
    Found in src/Debug/Collector/Pdo/Statement.php - About 35 mins to fix

      Define a constant instead of duplicating this literal "PDOStatement" 3 times.
      Open

              return \call_user_func_array(['PDOStatement', 'bindColumn'], $args);
      Severity: Critical
      Found in src/Debug/Collector/Pdo/Statement.php by sonar-php

      Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

      On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

      Noncompliant Code Example

      With the default threshold of 3:

      function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

      Compliant Solution

      ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

      Exceptions

      To prevent generating some false-positives, literals having less than 5 characters are excluded.

      There are no issues that match your filters.

      Category
      Status