bkdotcom/PHPDebugConsole

View on GitHub
src/Debug/Dump/Html/Group.php

Summary

Maintainability
A
0 mins
Test Coverage
A
98%

Define a constant instead of duplicating this literal "level" 3 times.
Open

            'level' => null,
Severity: Critical
Found in src/Debug/Dump/Html/Group.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Define a constant instead of duplicating this literal "method" 4 times.
Open

        $method = $logEntry['method'];
Severity: Critical
Found in src/Debug/Dump/Html/Group.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Define a constant instead of duplicating this literal "<span class="" times.></span>
Open

            return '<span class="' . $labelClasses . '">' . $label . '</span>';
Severity: Critical
Found in src/Debug/Dump/Html/Group.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Define a constant instead of duplicating this literal "class" 4 times.
Open

                'class' => 'group-header',
Severity: Critical
Found in src/Debug/Dump/Html/Group.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Unexpected tabs found.
Open

    public function build(LogEntry $logEntry, array $logEntryAttribs)
Severity: Minor
Found in src/Debug/Dump/Html/Group.php by editorconfig

Unexpected tabs found.
Open

            : '<span class="' . $labelClasses . '">' . $label . ':</span> '
Severity: Minor
Found in src/Debug/Dump/Html/Group.php by editorconfig

Unexpected tabs found.
Open

        $argStr = \implode(', ', $args);
Severity: Minor
Found in src/Debug/Dump/Html/Group.php by editorconfig

Unexpected tabs found.
Open

                . $argStr
Severity: Minor
Found in src/Debug/Dump/Html/Group.php by editorconfig

Unexpected tabs found.
Open

    /** @var Dumper  */
Severity: Minor
Found in src/Debug/Dump/Html/Group.php by editorconfig

Unexpected tabs found.
Open

            return '<span class="' . $labelClasses . '">' . $label . '</span>';
Severity: Minor
Found in src/Debug/Dump/Html/Group.php by editorconfig

Unexpected tabs found.
Open

                . $argStr;
Severity: Minor
Found in src/Debug/Dump/Html/Group.php by editorconfig

Unexpected tabs found.
Open

        foreach ($args as $k => $v) {
Severity: Minor
Found in src/Debug/Dump/Html/Group.php by editorconfig

Unexpected tabs found.
Open

            ? '<span class="' . $labelClasses . '">' . $label . '(</span>'
Severity: Minor
Found in src/Debug/Dump/Html/Group.php by editorconfig

Unexpected tabs found.
Open

        $this->logEntryAttribs = $logEntryAttribs;
Severity: Minor
Found in src/Debug/Dump/Html/Group.php by editorconfig

Unexpected tabs found.
Open

            $args[$k] = $this->dumper->valDumper->dump($v);
Severity: Minor
Found in src/Debug/Dump/Html/Group.php by editorconfig

Unexpected tabs found.
Open

                . '<span class="' . $labelClasses . '">)</span>'
Severity: Minor
Found in src/Debug/Dump/Html/Group.php by editorconfig

Unexpected tabs found.
Open

        }
Severity: Minor
Found in src/Debug/Dump/Html/Group.php by editorconfig

Unexpected tabs found.
Open

    {
Severity: Minor
Found in src/Debug/Dump/Html/Group.php by editorconfig

Unexpected tabs found.
Open

        }
Severity: Minor
Found in src/Debug/Dump/Html/Group.php by editorconfig

There are no issues that match your filters.

Category
Status