Sign upLogin

bkdotcom/PHPDebugConsole

View on GitHub
Star
src/Debug/Dump/Html/Object/ExtendsImplements.php

Summary

Maintainability
A
35 mins
Test Coverage
A
92%

Method dumpExtendsImplements has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    private function dumpExtendsImplements(array $listOrTree, $label, $treeClass, $itemClass, array $interfacesCollapse = array())
Severity: Minor
Found in src/Debug/Dump/Html/Object/ExtendsImplements.php - About 35 mins to fix

    Define a constant instead of duplicating this literal "extends" 4 times.
    Open

            $extends = $this->getItems($abs, 'extends');
    Severity: Critical
    Found in src/Debug/Dump/Html/Object/ExtendsImplements.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    Define a constant instead of duplicating this literal "implements" 3 times.
    Open

            $interfaces = $this->getItems($abs, 'implements');
    Severity: Critical
    Found in src/Debug/Dump/Html/Object/ExtendsImplements.php by sonar-php

    Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

    On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

    Noncompliant Code Example

    With the default threshold of 3:

    function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

    Compliant Solution

    ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

    Exceptions

    To prevent generating some false-positives, literals having less than 5 characters are excluded.

    There are no issues that match your filters.

    Category
    Status