Sign upLogin

bkdotcom/PHPDebugConsole

View on GitHub
Star
src/Debug/Framework/Laravel/ServiceProvider.php

Summary

Maintainability
A
0 mins
Test Coverage

Rename "$modelCounts" which has the same name as the field declared at line 34.
Open

        $modelCounts = $this->buildModelCountTable($tableInfoRows);
Severity: Major
Found in src/Debug/Framework/Laravel/ServiceProvider.php by sonar-php

Shadowing fields with a local variable is a bad practice that reduces code readability: it makes it confusing to know whether the field or the variable is being used.

Noncompliant Code Example

class Foo {
  public $myField;

  public function doSomething() {
    $myField = 0;
    ...
  }
}

See

Define a constant instead of duplicating this literal "events" 6 times.
Open

        if (!$this->shouldCollect('cacheEvents') || !isset($this->app['events'])) {
Severity: Critical
Found in src/Debug/Framework/Laravel/ServiceProvider.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Define a constant instead of duplicating this literal "config" 6 times.
Open

        $config = ArrayUtil::mergeDeep($this->app['config']->get('phpDebugConsole'), array(
Severity: Critical
Found in src/Debug/Framework/Laravel/ServiceProvider.php by sonar-php

Duplicated string literals make the process of refactoring error-prone, since you must be sure to update all occurrences.

On the other hand, constants can be referenced from many places, but only need to be updated in a single place.

Noncompliant Code Example

With the default threshold of 3:

function run() {
  prepare('action1');                              // Non-Compliant - 'action1' is duplicated 3 times
  execute('action1');
  release('action1');
}

Compliant Solution

ACTION_1 = 'action1';

function run() {
  prepare(ACTION_1);
  execute(ACTION_1);
  release(ACTION_1);
}

Exceptions

To prevent generating some false-positives, literals having less than 5 characters are excluded.

Rename "$modelCounts" which has the same name as the field declared at line 34.
Open

        $modelCounts = array();
Severity: Major
Found in src/Debug/Framework/Laravel/ServiceProvider.php by sonar-php

Shadowing fields with a local variable is a bad practice that reduces code readability: it makes it confusing to know whether the field or the variable is being used.

Noncompliant Code Example

class Foo {
  public $myField;

  public function doSomething() {
    $myField = 0;
    ...
  }
}

See

Rename "$debug" which has the same name as the field declared at line 33.
Open

        $debug = $this->debug->getChannel('Models', array(
Severity: Major
Found in src/Debug/Framework/Laravel/ServiceProvider.php by sonar-php

Shadowing fields with a local variable is a bad practice that reduces code readability: it makes it confusing to know whether the field or the variable is being used.

Noncompliant Code Example

class Foo {
  public $myField;

  public function doSomething() {
    $myField = 0;
    ...
  }
}

See

There are no issues that match your filters.

Category
Status