Sign upLogin

bkdotcom/PHPDebugConsole

View on GitHub
Star
src/Teams/AbstractItem.php

Summary

Maintainability
A
40 mins
Test Coverage
C
72%

Reduce the number of returns of this function 5, down to the maximum allowed 3.
Open

    private static function assertTypeCheck($value, $type)
Severity: Major
Found in src/Teams/AbstractItem.php by sonar-php

Having too many return statements in a function increases the function's essential complexity because the flow of execution is broken each time a return statement is encountered. This makes it harder to read and understand the logic of the function.

Noncompliant Code Example

With the default threshold of 3:

function myFunction(){ // Noncompliant as there are 4 return statements
  if (condition1) {
    return true;
  } else {
    if (condition2) {
      return false;
    } else {
      return true;
    }
  }
  return false;
}

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    protected static function assertType($value, $type, $allowNull = true)
    {
        if ($allowNull && $value === null) {
            return;
        }
Severity: Minor
Found in src/Teams/AbstractItem.php and 1 other location - About 40 mins to fix
src/Promise/Utils.php on lines 38..52

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status